Skip to content

Add documentation samples for binary classifiers using the dynamic API #1362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sfilipi opened this issue Oct 24, 2018 · 5 comments
Closed
Labels
API Issues pertaining the friendly API documentation Related to documentation of ML.NET good first issue Good for newcomers up-for-grabs A good issue to fix if you are trying to contribute to the project

Comments

@sfilipi
Copy link
Member

sfilipi commented Oct 24, 2018

Similar to PR #1361 we need code samples to reference from the new MLContext catalog extensions for all binary learners.

Reference to the sample in PR #1361 and add samples for the following binary trainers.
Cross reference those samples from the respective extensions on the catalog files.

Trainers:
SGD
LogisticRegression
FFM
FastTree
LightGBM

@sfilipi sfilipi added help wanted good first issue Good for newcomers API Issues pertaining the friendly API up-for-grabs A good issue to fix if you are trying to contribute to the project documentation Related to documentation of ML.NET labels Oct 24, 2018
@jwood803
Copy link
Contributor

jwood803 commented Jan 7, 2019

@sfilipi Not sure if this is exactly what is needed, but I have this example using Logistic Regression if it helps.

@sfilipi
Copy link
Member Author

sfilipi commented Jan 9, 2019

@jwood803 that example is perfect. DO you have interest/time to contribute it to the repo here, under the Microsoft.M.Samples project, and reference it from the LogisticRegression catalog? Unfortunately, it would have to be a different dataset, maybe the "adult" one, as we don't have permission to use the Titanic data.

@jwood803
Copy link
Contributor

jwood803 commented Jan 9, 2019

@sfilipi I'll be glad to put it under the samples project. Just to make sure, I should use this dataset, correct?

@sfilipi
Copy link
Member Author

sfilipi commented Jan 9, 2019

Anyone of the datasets in this folder should do. We can't use datasets outside of this repo...

Look at this PR, for a guide on how to link the sample back to the code it illustrates.

Thanks for taking this @jwood803 ! Let's leave the issue open, since there are another 4 trainer estimators to illustrate.

@sfilipi
Copy link
Member Author

sfilipi commented Apr 23, 2019

This is now complete. Progress was also tracked through: #2522

@sfilipi sfilipi closed this as completed Apr 23, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
API Issues pertaining the friendly API documentation Related to documentation of ML.NET good first issue Good for newcomers up-for-grabs A good issue to fix if you are trying to contribute to the project
Projects
None yet
Development

No branches or pull requests

2 participants