You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
TextLoader needs to hide the constructor that has Arguments, and also expose the HasHeader and SeparatorChars to be non-advanced parameters.
-- old description -- TextLoader presently accepts a parameter called column for the array of columns to read. That seems odd, given that almost always, multiple columns are passed. Hence, it would be more natural to call that parameter columns.
The text was updated successfully, but these errors were encountered:
@markusweimer that's not exactly correct. TextLoader takes Arguments as a parameter, and the arguments class has a field called Column. This is actually a common pattern in our codebase to use singular nouns for things that are internally arrays: it's better in command line to have loader=Text{column=Foo:TX:0 column=Bar:R4:1}
than it is to have loader=Text{columns=Foo:TX:0 columns=Bar:R4:1}.
However, I don't think the constructor that takes TextLoader.Arguments needs to be public altogether. We should improve the other constructor to have non-advanced parameters, and also do #1515 .
Zruty0
changed the title
TextLoader should use columns as a parameter, not column
TextLoader should have only one constructor, that doesn't take Arguments as a parameter
Nov 14, 2018
TextLoader
needs to hide the constructor that hasArguments
, and also expose theHasHeader
andSeparatorChars
to be non-advanced parameters.-- old description --
TextLoader
presently accepts a parameter calledcolumn
for the array of columns to read. That seems odd, given that almost always, multiple columns are passed. Hence, it would be more natural to call that parametercolumns
.The text was updated successfully, but these errors were encountered: