Skip to content

The ColumnInfo structure should live in the estimators, rather than transformers #1760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sfilipi opened this issue Nov 28, 2018 · 3 comments
Assignees
Labels
API Issues pertaining the friendly API

Comments

@sfilipi
Copy link
Member

sfilipi commented Nov 28, 2018

For OneHotEncoding estimator/transformer, ColumnInfo lives in the estimator.
For most other pairs, ColumnInfo lives in the transformer.

Standardize their location.

I think they should live in the estimator, since they are mostly used on Estimator definition.

@sfilipi
Copy link
Member Author

sfilipi commented Nov 28, 2018

@Zruty0, @CESARDELATORRE moving them to the estimator sounds good? it would be another breaking change.

@sfilipi sfilipi added the API Issues pertaining the friendly API label Nov 29, 2018
@TomFinley
Copy link
Contributor

Hi @sfilipi I just ran into this wile trying to use ValueToKeyMappingEstimator... it's ColumnInfo is for some reason off in the transformer, not the estimator. Yes should fix.

@artidoro
Copy link
Contributor

We have completed this work for all public ColumnInfo objects.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
API Issues pertaining the friendly API
Projects
None yet
Development

No branches or pull requests

4 participants