You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This has just one column specified, that is, there is no convenient way to map an input to an output column and have the mapping have a distinct names, without working through the params overload which is a bit less convenient. This is inconsistent with the direction summarized by @sfilipi in #2064 as well as some of our other APIs. For example, in this same file:
This method should be similar to the others in terms of the string outputColumnName, string inputColumnName = null signature. Note that this mistake extends down into the associated estimator and transformer constructors as well, so it will have to be fixed there as well.
Pursuant to #2064 and the work done in #2239, column mapping transforms are to have an output and input column. However, I notice something like this:
machinelearning/src/Microsoft.ML.Data/Transforms/ConversionsExtensionsCatalog.cs
Lines 72 to 73 in 578c188
This has just one column specified, that is, there is no convenient way to map an input to an output column and have the mapping have a distinct names, without working through the
params
overload which is a bit less convenient. This is inconsistent with the direction summarized by @sfilipi in #2064 as well as some of our other APIs. For example, in this same file:machinelearning/src/Microsoft.ML.Data/Transforms/ConversionsExtensionsCatalog.cs
Lines 30 to 31 in 578c188
machinelearning/src/Microsoft.ML.Data/Transforms/ConversionsExtensionsCatalog.cs
Lines 49 to 50 in 578c188
This method should be similar to the others in terms of the
string outputColumnName, string inputColumnName = null
signature. Note that this mistake extends down into the associated estimator and transformer constructors as well, so it will have to be fixed there as well./cc @sfilipi
The text was updated successfully, but these errors were encountered: