Skip to content

OvaModelParameters is not strongly-typed #2467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wschin opened this issue Feb 7, 2019 · 1 comment
Open

OvaModelParameters is not strongly-typed #2467

wschin opened this issue Feb 7, 2019 · 1 comment
Assignees
Labels
API Issues pertaining the friendly API P1 Priority of the issue for triage purpose: Needs to be fixed soon.

Comments

@wschin
Copy link
Member

wschin commented Feb 7, 2019

In the constructor of 'OvaModelParameters`,

        using TScalarPredictor = IPredictorProducing<float>;
        ...
        internal static OvaModelParameters Create(IHost host,  OutputFormula outputFormula, TScalarPredictor[] predictors)
        {
        ...
        }

we remove the type information of predictors by forcing them to be IPredictorProducing<float>. To make all multi-class classifiers' outputting strongly-typed models. We need to make OvaModelParameters strongly-typed.

@wschin wschin self-assigned this Feb 7, 2019
@shauheen shauheen added the API Issues pertaining the friendly API label Feb 11, 2019
@wschin wschin added the P0 Priority of the issue for triage purpose: IMPORTANT, needs to be fixed right away. label May 21, 2019
@wschin
Copy link
Member Author

wschin commented May 21, 2019

Without strongly-typed OVA, user can't access the trained models because variable can be accessed when type is known.

@codemzs codemzs assigned ganik and unassigned wschin May 22, 2019
@codemzs codemzs assigned michaelgsharp and unassigned ganik Jun 12, 2019
@najeeb-kazmi najeeb-kazmi added P1 Priority of the issue for triage purpose: Needs to be fixed soon. and removed P0 Priority of the issue for triage purpose: IMPORTANT, needs to be fixed right away. labels Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Issues pertaining the friendly API P1 Priority of the issue for triage purpose: Needs to be fixed soon.
Projects
None yet
5 participants