Skip to content

Calibrator estimators as successor to ICalibratorTrainer #2515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TomFinley opened this issue Feb 12, 2019 · 0 comments · Fixed by #2526
Closed

Calibrator estimators as successor to ICalibratorTrainer #2515

TomFinley opened this issue Feb 12, 2019 · 0 comments · Fixed by #2526
Assignees
Labels
API Issues pertaining the friendly API

Comments

@TomFinley
Copy link
Contributor

One of the legacy interfaces we have is the calibrator trainer.

public interface ICalibratorTrainer

This interface is unsuitable to being a public class as part of the IEstimator/ITransformer idioms, being more of implementation interface for the infrastructure of the calibrators. So we don't want that exposed, but we do nonetheless want the ability to given some data, produce a calibrator out of it.

Happily we almost have it, in the form of the subclasses of the calibrator estimators.

public abstract class CalibratorEstimatorBase<TCalibratorTrainer, TICalibrator> : IEstimator<CalibratorTransformer<TICalibrator>>

The only real trouble is that this object assumes, at a fairly deep level, that internally there is an IPredictor in it, but as far as I know this is mostly due to some internal convenience code that I hope could be refactored to just take an IDataView directly.

This might be viewed as a sub-part of #1871.

/ccing @sfilipi for visibility.

@TomFinley TomFinley self-assigned this Feb 12, 2019
@TomFinley TomFinley added the API Issues pertaining the friendly API label Feb 12, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
API Issues pertaining the friendly API
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant