Skip to content

FastTree EarlyStoppingMetric is an int but only accepts specific values #2521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rogancarr opened this issue Feb 13, 2019 · 1 comment
Closed

FastTree EarlyStoppingMetric is an int but only accepts specific values #2521

rogancarr opened this issue Feb 13, 2019 · 1 comment
Assignees
@codemzs
Labels
API Issues pertaining the friendly API
Milestone
0319

Comments

@rogancarr
Copy link
Contributor

In the current Options for FastTree (and GAMs), EarlyStoppingMetric is an int, but only specific values are accepted (e.g. 1 or 2 for regression, 1 or 3 for ranking).

It would be much cleaner if this was an enum.
@rogancarr rogancarr added the API Issues pertaining the friendly API label Feb 13, 2019
@Ivanidzo4ka Ivanidzo4ka mentioned this issue Feb 19, 2019
Closed
@codemzs codemzs self-assigned this Feb 26, 2019
@codemzs codemzs added this to the 0219 milestone Feb 26, 2019
@codemzs codemzs mentioned this issue Feb 26, 2019
Closed
@shauheen shauheen modified the milestones: 0219, 0319 Mar 5, 2019
@Ivanidzo4ka
Copy link
Contributor

I believe this one was closed in #2753

@ghost ghost locked as resolved and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@codemzs codemzs

Labels
API Issues pertaining the friendly API
Projects
None yet
Milestone
0319
Development

Successfully merging a pull request may close this issue.

Make EarlyStoppingMetric an enum. codemzs/machinelearning
4 participants
@codemzs @Ivanidzo4ka @shauheen @rogancarr