Skip to content

Cleaning of overload Fit functions #2553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Ivanidzo4ka opened this issue Feb 14, 2019 · 1 comment
Closed

Cleaning of overload Fit functions #2553

Ivanidzo4ka opened this issue Feb 14, 2019 · 1 comment
Assignees
@Ivanidzo4ka
Labels
API Issues pertaining the friendly API
Milestone
0219

Comments

@Ivanidzo4ka
Copy link
Contributor

  • We shouldn't use IPredictor interface for initialPredictor, we should specify proper class type.
  • initialPredictor should be renamed to modelParameters
@Ivanidzo4ka Ivanidzo4ka added the API Issues pertaining the friendly API label Feb 14, 2019
@Ivanidzo4ka Ivanidzo4ka mentioned this issue Feb 14, 2019
Merged
@Ivanidzo4ka
Copy link
Contributor Author

related to #2251

@Ivanidzo4ka Ivanidzo4ka mentioned this issue Feb 15, 2019
Merged
@shauheen shauheen added this to the 0219 milestone Feb 16, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Ivanidzo4ka Ivanidzo4ka

Labels
API Issues pertaining the friendly API
Projects
None yet
Milestone
0219
Development

No branches or pull requests
2 participants
@Ivanidzo4ka @shauheen