Skip to content

Catalog.NormalizeText doesn't offer a multi-column version #2734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rauhs opened this issue Feb 26, 2019 · 2 comments
Open

Catalog.NormalizeText doesn't offer a multi-column version #2734

rauhs opened this issue Feb 26, 2019 · 2 comments
Assignees
Labels
API Issues pertaining the friendly API enhancement New feature or request P2 Priority of the issue for triage purpose: Needs to be fixed at some point.

Comments

@rauhs
Copy link
Contributor

rauhs commented Feb 26, 2019

API: Usually most catalog functions will have an overloaded method to supply multiple columns.

E.g. ctx.Transforms.Text.TokenizeWords(). Though, ctx.Transforms.Text.NormalizeText() only offers single input column to single output column. Was this overlooked or by-design?

@Ivanidzo4ka
Copy link
Contributor

I believe it was just overlooked.
@artidoro any chance you that can be part of your columnOptions PR?

@Ivanidzo4ka Ivanidzo4ka added the API Issues pertaining the friendly API label Mar 15, 2019
@artidoro
Copy link
Contributor

artidoro commented Mar 15, 2019

Yes I can work on that @Ivanidzo4ka!

@rauhs thanks for reporting this. It is actually part of a larger issue that we had in the API. The ColumnOptions was not consistent with other parts of our API, and was immutable, we are moving towards something that looks similar to the Options in the trainers.

The process to get there will be in two steps, the first will hide all the ColumnOptions and keep them internal, the second will make the Options available as a mutable class. This will also allow specifying multi column mappings.

For more info see #2884

@artidoro artidoro self-assigned this Mar 15, 2019
@antoniovs1029 antoniovs1029 added enhancement New feature or request P2 Priority of the issue for triage purpose: Needs to be fixed at some point. labels Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Issues pertaining the friendly API enhancement New feature or request P2 Priority of the issue for triage purpose: Needs to be fixed at some point.
Projects
None yet
Development

No branches or pull requests

4 participants