Skip to content

Consistency in feature/label/weight/group names in LearnerInputBase classes #2760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ivanidzo4ka opened this issue Feb 27, 2019 · 0 comments · Fixed by #2748
Closed

Consistency in feature/label/weight/group names in LearnerInputBase classes #2760

Ivanidzo4ka opened this issue Feb 27, 2019 · 0 comments · Fixed by #2748
Assignees
Labels
API Issues pertaining the friendly API
Milestone

Comments

@Ivanidzo4ka
Copy link
Contributor

We have this class which is base class for all(almost except KMeans) Trainers.Options

public abstract class LearnerInputBase

In trainer catalog we use following names:

/// <param name="labelColumnName">The name of the label column.</param>
/// <param name="featureColumnName">The name of the feature column.</param>
/// <param name="rowGroupColumnName">The name of the group column.</param>
/// <param name="exampleWeightColumnName">The name of the example weight column (optional).</param>

It doesn't feel right to have this names in catalog and have other names in options class.
So we should make them consistent and update LearnerInputBase class to ones we use in catalog.

@Ivanidzo4ka Ivanidzo4ka added the API Issues pertaining the friendly API label Feb 27, 2019
@ganik ganik self-assigned this Feb 27, 2019
@shauheen shauheen added this to the 0219 milestone Feb 28, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
API Issues pertaining the friendly API
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants