Skip to content

SupportedMetric.ByName() method no longer functions #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
george-microsoft opened this issue May 31, 2018 · 4 comments
Closed

SupportedMetric.ByName() method no longer functions #279

george-microsoft opened this issue May 31, 2018 · 4 comments
Assignees
@george-microsoft
Labels
bug Something isn't working
Milestone
0618

Comments

@george-microsoft
Copy link
Contributor

george-microsoft commented May 31, 2018 •
edited
Loading

PipelineInference/AutoInference.cs/SupportedMetric.ByName() method no longer works as expected, since names of fields in SupportedMetric no longer match their values. Need to change method to work with latest commits fixing the names of the metric values, comparing the values and not the field names themselves.
@george-microsoft george-microsoft added the bug Something isn't working label May 31, 2018
@george-microsoft george-microsoft self-assigned this May 31, 2018
@george-microsoft george-microsoft mentioned this issue May 31, 2018
Merged
@shauheen shauheen added this to the 0618 milestone Jun 1, 2018
@Ivanidzo4ka
Copy link
Contributor

Can we close this one?

@george-microsoft
Copy link
Contributor Author

Yes, the fix should be merged.

@Ivanidzo4ka
Copy link
Contributor

But it's merged already

@george-microsoft
Copy link
Contributor Author

Yes, I meant that it should already be in there. Closing the issue.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@george-microsoft george-microsoft

Labels
bug Something isn't working
Projects
None yet
Milestone
0618
Development

No branches or pull requests
3 participants
@Ivanidzo4ka @shauheen @george-microsoft