-
Notifications
You must be signed in to change notification settings - Fork 1.9k
API Reference needs to include expected column types #3127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Note that this also applies to Evaluate and CrossValidate api references. |
I think we should put the suggestion for the data type of the label in the summary of the trainer extensions documentation, since that is the string that intellisense displays when it gets added. |
I flushed out an example with the FieldAwareFactorizationMachine. I put this on the extension method. The FieldAwareFactorizationMachine takes in a featureColumnName, labelColumnName and exampleWeightColumnName -- for each parameter that is a column name, these now have additional text in the param reference that explains the expected column type. The FieldAwareFactorizationMachine also adds columns to the transformed data. In order to document the added columns, I added this to remarks using the xml docs table (really as a list with the type set as table). The table has the column name, expected column type, and a description of what the column is @wschin - this could be on the GetOutputSchema instead, but if we document the extension method rather than the class, this would be harder to find. @sfilipi the parameter reference for label column can be dupped in the summary if needed. Here is the sample:
|
cc @shmoradims @glebuk as well. |
I've broken down the items that need to be updated based upon the catalogs:
|
I believe the input/output types were addressed for all trainers and transforms during the API reference project. Here's an example for FFM with input/output sub-section in remarks: |
Issue
Our API documentation for trainers, evaluate and cross validate need to specify the expected column types.
For example:
Taken from here:
Matrix Factorization Help
Note that this takes:
The type string provides no information on the actual expected/supported column type.
Expected
There needs to be more documentation regarding the column types that trainers are expecting and if that trainer will add additional columns as a result of the transformation.
Suggestion
This can be added to the parameter description, for example:
The name of the label column. The label column must be one of the following ColumnType: DataKind.Int64, DataKind.Float,...</param>
Additional content regarding if columns are added and what those columns are should be added in the Remarks section. Columns that are added should also include their ColumnType as well.
The text was updated successfully, but these errors were encountered: