Skip to content

Remove Console.Readline at the end of the samples #3279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
codemzs opened this issue Apr 10, 2019 · 0 comments · Fixed by #3278
Closed

Remove Console.Readline at the end of the samples #3279

codemzs opened this issue Apr 10, 2019 · 0 comments · Fixed by #3278
Assignees
Labels
code-sanitation Code consistency, maintainability, and best practices, moreso than any public API.

Comments

@codemzs
Copy link
Member

codemzs commented Apr 10, 2019

There are two samples that have ReadLine() in the end, presumably to prevent the window from closing but this is not needed because VS prevents the window from closing and also this pattern is inconsistent from rest of the samples. This interferes with the test that runs all the samples to ensure samples are working and not throwing any runtime exceptions.

@codemzs codemzs added the code-sanitation Code consistency, maintainability, and best practices, moreso than any public API. label Apr 10, 2019
@codemzs codemzs added this to the 0419 milestone Apr 10, 2019
@codemzs codemzs self-assigned this Apr 10, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
code-sanitation Code consistency, maintainability, and best practices, moreso than any public API.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant