Skip to content

Stop using Preview structure and API in samples. #3350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
codemzs opened this issue Apr 16, 2019 · 0 comments · Fixed by #3379
Closed

Stop using Preview structure and API in samples. #3350

codemzs opened this issue Apr 16, 2019 · 0 comments · Fixed by #3379
Assignees
@codemzs
Labels
bug Something isn't working code-sanitation Code consistency, maintainability, and best practices, moreso than any public API.

Comments

@codemzs
Copy link
Member

codemzs commented Apr 16, 2019 •
edited
Loading

From PR #3307 and @TomFinley 's comment it was learnt that samples should be rewritten to not use "preview" structure because we're writing sample code using a structure expressly and clearly intended purely for debugging in a preview window anyway. There are a number of samples that use preview structure, I will start converting these samples in batches and replace the usage of preview API/structure with something more appropriate like IDataView + getter or Enumerable(with class). We definitely don't want to be educating our users the wrong thing.

CC: @TomFinley @shmoradims @natke @shauheen
@codemzs codemzs added bug Something isn't working code-sanitation Code consistency, maintainability, and best practices, moreso than any public API. labels Apr 16, 2019
@codemzs codemzs added this to the 0419 milestone Apr 16, 2019
@codemzs codemzs self-assigned this Apr 16, 2019
This was referenced Apr 16, 2019
Merged
Merged
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Mar 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@codemzs codemzs

Labels
bug Something isn't working code-sanitation Code consistency, maintainability, and best practices, moreso than any public API.
Projects
None yet
Milestone
No milestone
1 participant
@codemzs