You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[Argument(ArgumentType.AtMostOnce,HelpText="Column to use for example groupId",ShortName="groupId",SortOrder=5,Visibility=ArgumentAttribute.VisibilityType.EntryPointsOnly)]
publicstringRowGroupColumnName=null;
We need to update the default and align it with the simple constructor.
The text was updated successfully, but these errors were encountered:
I am afraid that this will require a breaking API change which at this point we can't do. This would be something that we should consider changing for 2.0.
artidoro
added
breaking
and removed
P0
Priority of the issue for triage purpose: IMPORTANT, needs to be fixed right away.
labels
May 29, 2019
I would expect the ranking trainer to throw if it doesn't have a RowGroupColumnName defined.
Hence, I don't see this as a breaking change, since without it the user's pipeline (even if it runs) is broken as the result won't have utility. This questions our definition of a breaking API change.
The
Options
class of the ranking trainers (FastTree
andLightGbm
) defaults toRowGroupColumnName = null
.This is:
RowGroupColumnName
defaults toGroupId
Here are the lines where the row group column name is set:
machinelearning/src/Microsoft.ML.Data/Training/TrainerInputBase.cs
Lines 106 to 110 in 738e5d5
We need to update the default and align it with the simple constructor.
The text was updated successfully, but these errors were encountered: