Skip to content

Rename tlcresources in Resource manager #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ivanidzo4ka opened this issue Jul 17, 2018 · 1 comment
Closed

Rename tlcresources in Resource manager #546

Ivanidzo4ka opened this issue Jul 17, 2018 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@Ivanidzo4ka
Copy link
Contributor

        private const string DefaultUrl = "https://aka.ms/tlc-resources/";
      
        private static string TlcResourcesUrl

we have this TLC mentions in https://github.com/dotnet/machinelearning/blob/master/src/Microsoft.ML.Core/Utilities/ResourceManagerUtils.cs
and it would be nice to rename them to something ml.net specific.

In same time we need to make sure default url should point to valid location (we can't just rename it in code, we also need to update aka.ms)

@shauheen shauheen added the bug Something isn't working label Jul 18, 2018
@shauheen shauheen added this to the 0718 milestone Jul 18, 2018
@shauheen shauheen removed this from the 0718 milestone Aug 4, 2018
@shauheen shauheen added this to the 0918 milestone Sep 4, 2018
@justinormont
Copy link
Contributor

When doing this, be sure to point the old aka.ms links to the new aka.ms links. The maintains backwards compatibility by ensuring the old links (used in internal builds) still work.

In addition, pointing the old aka.ms links to the new aka.ms links reduces our long term work, as we then only have to maintain the new links.

@shauheen shauheen removed this from the 0918 milestone Sep 25, 2018
@ghost ghost locked as resolved and limited conversation to collaborators Mar 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants