Skip to content

[DataFrame] Allow quote escaping #6238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #6144
luisquintanilla opened this issue Jun 28, 2022 · 1 comment · Fixed by #6340
Closed
Tracked by #6144

[DataFrame] Allow quote escaping #6238

luisquintanilla opened this issue Jun 28, 2022 · 1 comment · Fixed by #6340
Labels
enhancement New feature or request loadsave Bugs related loading and saving data or models Microsoft.Data.Analysis All DataFrame related issues and PRs
Milestone
ML.NET Future

Comments

@luisquintanilla
Copy link
Contributor

Loading data from a column containing quotes inside a string shouldn't break.

"this is one column value which includes a "" character"
@luisquintanilla luisquintanilla added enhancement New feature or request Microsoft.Data.Analysis All DataFrame related issues and PRs labels Jun 28, 2022
@ghost ghost added the untriaged New issue has not been triaged label Jun 28, 2022
@luisquintanilla luisquintanilla added loadsave Bugs related loading and saving data or models and removed untriaged New issue has not been triaged labels Jun 28, 2022
@luisquintanilla luisquintanilla mentioned this issue Jun 28, 2022
Open
37 tasks
@michaelgsharp michaelgsharp added this to the ML.NET Future milestone Jul 11, 2022
@dakersnar
Copy link
Contributor

I believe this issue has been solved already for LoadCsv (I added unit tests to confirm this). However, I found bugs related to this in WriteCsv. I have a fix that will go up as soon as #6303 is merged.

@dakersnar dakersnar mentioned this issue Sep 27, 2022
Merged
@ghost ghost added the in-pr label Sep 27, 2022
@ghost ghost removed the in-pr label Oct 4, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request loadsave Bugs related loading and saving data or models Microsoft.Data.Analysis All DataFrame related issues and PRs
Projects
None yet
Milestone
ML.NET Future
Development

Successfully merging a pull request may close this issue.

Fix problems with DataFrame WriteCsv when quotes are present in data dakersnar/machinelearning
3 participants
@dakersnar @luisquintanilla @michaelgsharp