From 5ce4009560edbe14170f536fec5cca167696a57a Mon Sep 17 00:00:00 2001 From: Eric Erhardt Date: Tue, 19 Feb 2019 10:55:26 -0600 Subject: [PATCH] Address PR feedback from #2579 We don't need a TryConvert method, we already have a TryParse, which can be used instead. --- src/Microsoft.ML.Data/Data/Conversion.cs | 11 ----------- .../DataLoadSave/Text/TextLoaderParser.cs | 4 ++-- 2 files changed, 2 insertions(+), 13 deletions(-) diff --git a/src/Microsoft.ML.Data/Data/Conversion.cs b/src/Microsoft.ML.Data/Data/Conversion.cs index 1921d3f852..2ea1717cb4 100644 --- a/src/Microsoft.ML.Data/Data/Conversion.cs +++ b/src/Microsoft.ML.Data/Data/Conversion.cs @@ -1585,17 +1585,6 @@ public void Convert(in TX span, ref I4 value) { value = ParseI4(in span); } - public bool TryConvert(in TX span, ref I4 value) - { - TryParseSigned(I4.MaxValue, in span, out long? res); - if (res.HasValue) - { - value = (I4)res.GetValueOrDefault(); - return true; - } - - return false; - } public void Convert(in TX span, ref U4 value) { value = ParseU4(in span); diff --git a/src/Microsoft.ML.Data/DataLoadSave/Text/TextLoaderParser.cs b/src/Microsoft.ML.Data/DataLoadSave/Text/TextLoaderParser.cs index 5dddc064dc..c0ce3935d0 100644 --- a/src/Microsoft.ML.Data/DataLoadSave/Text/TextLoaderParser.cs +++ b/src/Microsoft.ML.Data/DataLoadSave/Text/TextLoaderParser.cs @@ -1016,8 +1016,8 @@ public int GatherFields(ReadOnlyMemory lineSpan, ReadOnlySpan span, } var spanT = Fields.Spans[Fields.Count - 1]; - int csrc = 0; - if (!Conversions.Instance.TryConvert(in spanT, ref csrc) || csrc <= 0) + int csrc; + if (!Conversions.Instance.TryParse(in spanT, out csrc) || csrc <= 0) { _stats.LogBadFmt(ref scan, "Bad dimensionality or ambiguous sparse item. Use sparse=- for non-sparse file, and/or quote the value."); break;