[AppKit] Improve and simplify the manually bound constructors for NSOpenGLPixelFormat slightly. (#22716)

Improve and simplify the manually bound constructors for NSOpenGLPixelFormat by
using the same pattern we use elsewhere for manually bound constructors.

Author: rolfbjarne

src/AppKit/NSOpenGLPixelFormat.cs

@@ -38,46 +38,46 @@ namespace AppKit {
 	public partial class NSOpenGLPixelFormat {
 		static IntPtr selInitWithAttributes = Selector.GetHandle ("initWithAttributes:");
 
-		/// <param name="attribs">To be added.</param>
-		///         <summary>To be added.</summary>
-		///         <remarks>To be added.</remarks>
-		public NSOpenGLPixelFormat (NSOpenGLPixelFormatAttribute [] attribs) : base (NSObjectFlag.Empty)
+		/// <summary>Create a new <see cref="NSOpenGLPixelFormat" /> instance with the specified attributes.</summary>
+		/// <param name="attribs">The attributes to initialize the new <see cref="NSOpenGLPixelFormat" /> instance with.</param>
+		public NSOpenGLPixelFormat (NSOpenGLPixelFormatAttribute [] attribs)
+			: base (NSObjectFlag.Empty)
 		{
 			if (attribs is null)
-				throw new ArgumentNullException ("attribs");
+				throw new ArgumentNullException (nameof (attribs));
 
 			unsafe {
 				NSOpenGLPixelFormatAttribute [] copy = new NSOpenGLPixelFormatAttribute [attribs.Length + 1];
 				Array.Copy (attribs, 0, copy, 0, attribs.Length);
 
 				fixed (NSOpenGLPixelFormatAttribute* pArray = copy) {
 					if (IsDirectBinding) {
-						Handle = ObjCRuntime.Messaging.IntPtr_objc_msgSend_IntPtr (this.Handle, selInitWithAttributes, new IntPtr ((void*) pArray));
+						InitializeHandle (ObjCRuntime.Messaging.IntPtr_objc_msgSend_IntPtr (this.Handle, selInitWithAttributes, new IntPtr ((void*) pArray)), "initWithAttributes:");
 					} else {
-						Handle = ObjCRuntime.Messaging.IntPtr_objc_msgSendSuper_IntPtr (this.SuperHandle, selInitWithAttributes, new IntPtr ((void*) pArray));
+						InitializeHandle (ObjCRuntime.Messaging.IntPtr_objc_msgSendSuper_IntPtr (this.SuperHandle, selInitWithAttributes, new IntPtr ((void*) pArray)), "initWithAttributes:");
 					}
 				}
 
 			}
 		}
 
-		/// <param name="attribs">To be added.</param>
-		///         <summary>To be added.</summary>
-		///         <remarks>To be added.</remarks>
-		public NSOpenGLPixelFormat (uint [] attribs) : base (NSObjectFlag.Empty)
+		/// <summary>Create a new <see cref="NSOpenGLPixelFormat" /> instance with the specified attributes.</summary>
+		/// <param name="attribs">The attributes to initialize the new <see cref="NSOpenGLPixelFormat" /> instance with.</param>
+		public NSOpenGLPixelFormat (uint [] attribs)
+			: base (NSObjectFlag.Empty)
 		{
 			if (attribs is null)
-				throw new ArgumentNullException ("attribs");
+				throw new ArgumentNullException (nameof (attribs));
 
 			unsafe {
 				uint [] copy = new uint [attribs.Length + 1];
 				Array.Copy (attribs, 0, copy, 0, attribs.Length);
 
 				fixed (uint* pArray = copy) {
 					if (IsDirectBinding) {
-						InitializeHandle (ObjCRuntime.Messaging.IntPtr_objc_msgSend_IntPtr (this.Handle, selInitWithAttributes, new IntPtr ((void*) pArray)));
+						InitializeHandle (ObjCRuntime.Messaging.IntPtr_objc_msgSend_IntPtr (this.Handle, selInitWithAttributes, new IntPtr ((void*) pArray)), "initWithAttributes:");
 					} else {
-						InitializeHandle (ObjCRuntime.Messaging.IntPtr_objc_msgSendSuper_IntPtr (this.SuperHandle, selInitWithAttributes, new IntPtr ((void*) pArray)));
+						InitializeHandle (ObjCRuntime.Messaging.IntPtr_objc_msgSendSuper_IntPtr (this.SuperHandle, selInitWithAttributes, new IntPtr ((void*) pArray)), "initWithAttributes:");
 					}
 				}
 
@@ -156,34 +156,11 @@ static uint [] ConvertToAttributes (object [] args)
 			return list.ToArray ();
 		}
 
-		/// <param name="attribs">To be added.</param>
-		///         <summary>To be added.</summary>
-		///         <remarks>To be added.</remarks>
-		public NSOpenGLPixelFormat (params object [] attribs) : this (ConvertToAttributes (attribs))
+		/// <summary>Create a new <see cref="NSOpenGLPixelFormat" /> instance with the specified attributes.</summary>
+		/// <param name="attribs">The attributes to initialize the new <see cref="NSOpenGLPixelFormat" /> instance with.</param>
+		public NSOpenGLPixelFormat (params object [] attribs)
+			: this (ConvertToAttributes (attribs))
 		{
-			if (attribs is null)
-				throw new ArgumentNullException ("attribs");
-
-			unsafe {
-				var copy = new NSOpenGLPixelFormatAttribute [attribs.Length + 1 /* null termination */];
-				for (int i = 0; i < attribs.Length; i++) {
-					var input = attribs [i];
-					if (input is NSOpenGLPixelFormatAttribute) {
-						copy [i] = (NSOpenGLPixelFormatAttribute) input;
-					} else {
-						copy [i] = (NSOpenGLPixelFormatAttribute) (int) input;
-					}
-				}
-
-				fixed (NSOpenGLPixelFormatAttribute* pArray = copy) {
-					if (IsDirectBinding) {
-						Handle = ObjCRuntime.Messaging.IntPtr_objc_msgSend_IntPtr (this.Handle, selInitWithAttributes, new IntPtr ((void*) pArray));
-					} else {
-						Handle = ObjCRuntime.Messaging.IntPtr_objc_msgSendSuper_IntPtr (this.SuperHandle, selInitWithAttributes, new IntPtr ((void*) pArray));
-					}
-				}
-
-			}
 		}
 	}
 }

tests/cecil-tests/SetHandleTest.KnownFailures.cs

@@ -6,8 +6,6 @@ namespace Cecil.Tests {
 	public partial class SetHandleTest {
 		static HashSet<string> knownFailuresNobodyCallsHandleSetter = new HashSet<string> {
 			"AddressBook.ABGroup::.ctor(AddressBook.ABRecord)",
-			"AppKit.NSOpenGLPixelFormat::.ctor(AppKit.NSOpenGLPixelFormatAttribute[])",
-			"AppKit.NSOpenGLPixelFormat::.ctor(System.Object[])",
 			"CoreFoundation.CFMutableString::.ctor(CoreFoundation.CFString,System.IntPtr)",
 			"CoreFoundation.CFMutableString::.ctor(System.String,System.IntPtr)",
 			"CoreFoundation.CFSocket::Initialize(CoreFoundation.CFRunLoop,CoreFoundation.CFSocket/CreateSocket)",