Skip to content

Commit 041b7d7

Browse files
thymikeeEsemesek
authored andcommitted
chore: bump flow to 0.94 (react-native-community#200)
Summary: --------- It's usually better to be on the latest available :D Test Plan: ---------- Green CI
1 parent 45ade50 commit 041b7d7

File tree

8 files changed

+10
-14
lines changed

8 files changed

+10
-14
lines changed

.flowconfig

+2-1
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ module.ignore_non_literal_requires=true
4242
[lints]
4343
all=warn
4444
unnecessary-optional-chain=off
45+
dynamic-export=off
4546

4647
# There is an ESLint rule for this
4748
unclear-type=off
@@ -64,4 +65,4 @@ untyped-import
6465
untyped-type-import
6566

6667
[version]
67-
^0.87.0
68+
^0.94.0

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
"chalk": "^2.4.2",
2525
"eslint": "^5.10.0",
2626
"eslint-plugin-prettier": "^3.0.1",
27-
"flow-bin": "^0.87.0",
27+
"flow-bin": "^0.94.0",
2828
"glob": "^7.1.3",
2929
"jest": "^24.0.0",
3030
"lerna": "^3.10.6",

packages/cli/src/cliEntry.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ const addCommand = (command: CommandT, ctx: ContextT) => {
119119
opt.command,
120120
opt.description,
121121
opt.parse || defaultOptParser,
122-
typeof opt.default === 'function' ? opt.default(ctx) : opt.default
122+
opt.default
123123
)
124124
);
125125

packages/cli/src/core/getPackageConfiguration.js

-1
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,5 @@ import type { PackageConfigurationT } from './types.flow';
1010
export default function getPackageConfiguration(
1111
folder: string
1212
): PackageConfigurationT {
13-
// $FlowFixMe: Non-literal require
1413
return require(path.join(folder, './package.json')).rnpm || {};
1514
}

packages/cli/src/core/types.flow.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ export type LocalCommandT = {
1818
command: string,
1919
description?: string,
2020
parse?: (val: string) => any,
21-
default?: ((ctx: ContextT) => mixed) | mixed,
21+
default?: string | boolean | number,
2222
}>,
2323
examples?: Array<{
2424
desc: string,

packages/cli/src/server/util/launchChrome.js

-3
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,6 @@
88
* @flow
99
*/
1010

11-
/* $FlowFixMe(>=0.54.0 site=react_native_oss) This comment suppresses an error
12-
* found when Flow v0.54 was deployed. To see the error delete this comment and
13-
* run Flow. */
1411
import opn from 'opn';
1512
import { execSync } from 'child_process';
1613
import logger from '../../util/logger';

packages/cli/src/util/loadMetroConfig.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
* Configuration file of Metro.
33
* @flow
44
*/
5-
import type { ConfigT } from 'metro-config/src/configTypes.flow';
65
import path from 'path';
76
import { createBlacklist } from 'metro';
87
import { loadConfig } from 'metro-config';
@@ -90,7 +89,7 @@ export default async function load(
9089
ctx: ContextT,
9190
// $FlowFixMe - troubles with empty object being inexact
9291
options?: ConfigOptionsT = {}
93-
): Promise<ConfigT> {
92+
) {
9493
const defaultConfig = getDefaultConfig(ctx);
9594

9695
const config = await loadConfig(

yarn.lock

+4-4
Original file line numberDiff line numberDiff line change
@@ -3555,10 +3555,10 @@ flat-cache@^1.2.1:
35553555
graceful-fs "^4.1.2"
35563556
write "^0.2.1"
35573557

3558-
flow-bin@^0.87.0:
3559-
version "0.87.0"
3560-
resolved "https://registry.yarnpkg.com/flow-bin/-/flow-bin-0.87.0.tgz#fab7f984d8cc767e93fa9eb01cf7d57ed744f19d"
3561-
integrity sha512-mnvBXXZkUp4y6A96bR5BHa3q1ioIIN2L10w5osxJqagAakTXFYZwjl0t9cT3y2aCEf1wnK6n91xgYypQS/Dqbw==
3558+
flow-bin@^0.94.0:
3559+
version "0.94.0"
3560+
resolved "https://registry.yarnpkg.com/flow-bin/-/flow-bin-0.94.0.tgz#b5d58fe7559705b73a18229f97edfc3ab6ffffcb"
3561+
integrity sha512-DYF7r9CJ/AksfmmB4+q+TyLMoeQPRnqtF1Pk7KY3zgfkB/nVuA3nXyzqgsIPIvnMSiFEXQcFK4z+iPxSLckZhQ==
35623562

35633563
flush-write-stream@^1.0.0:
35643564
version "1.0.3"

0 commit comments

Comments
 (0)