Skip to content

drush/policy.drush.inc incompatible with drush 9 #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zaporylie opened this issue Sep 12, 2017 · 5 comments
Closed

drush/policy.drush.inc incompatible with drush 9 #306

zaporylie opened this issue Sep 12, 2017 · 5 comments

Comments

@zaporylie
Copy link
Contributor

This is a story of the future but with Drush 9 pm-* policy (drush/policy.drush.inc) won't work anymore (no more drush hooks). I know I'm repeating myself but I still believe policy should become a standalone project configurable via composer.json. That way we could release another iteration at some point, compatible with Drush 9.

@weitzman
Copy link
Contributor

As of right now, Drush9 still reads legacy commandfiles and many hooks fire. Do you have a particular hook in mind?

@zaporylie
Copy link
Contributor Author

Didn't know that. Anyways - if hooks will become deprecated in favour of annotated plugins in one of the following Drush major versions we would have solve policy issue one way or another. I believe standalone drush policy package is the way to go.

Hook implementations I'm referring to:

function drush_policy_pm_updatecode_validate() {
  return _deny_message();
}
function drush_policy_pm_update_validate() {
  return _deny_message();
}
function drush_policy_pm_download_validate() {
  return _deny_message();
}

@zaporylie
Copy link
Contributor Author

@weitzman
Copy link
Contributor

none of that code matters anymore - pm-updatecode is removed in drush9. the file serves as documentation by example.

@weitzman
Copy link
Contributor

weitzman commented Feb 9, 2018

See #350

@weitzman weitzman closed this as completed Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants