Skip to content

Move drush/drush from a required dependency to a suggestion #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gnuget opened this issue Feb 15, 2018 · 3 comments
Closed

Move drush/drush from a required dependency to a suggestion #357

gnuget opened this issue Feb 15, 2018 · 3 comments

Comments

@gnuget
Copy link

gnuget commented Feb 15, 2018

I read #352 and I agree that all the non-required dependencies should be moved to suggestions and drush is also part of those.

So, can we move it as well and let the user decide which project she wants to use?

@gnuget gnuget changed the title Move drush/drush form a required dependency to a suggestion Move drush/drush from a required dependency to a suggestion Feb 15, 2018
@jackbravo
Copy link

I don't think they should be moved to suggested. Both drush and console are very useful as a starting point, which is what drupal-project gives: a useful starting point. I think without both of them, it becomes less useful. And since this is just a starting point, removing any of them I think is best left as an exercise to the user. Well, at least that is my opinion.

@FatherShawn
Copy link

After stating an opinion that we should should have both CLI in the same sections - I realize that I didn't state an opinion as to which. I'm with @jackbravo - I use them on every drupal project and would leave them both in the project dependencies. This project is for CLI management of a drupal project.

@pfrenssen
Copy link
Collaborator

As already discussed in the sister issue #352, we cannot move Drush to suggest because drupal-project depends on it, it is used in the test suite. Also I suggested to move Drush to require-dev in the PR (#353), but it was pointed out that Drush is currently installed on most production sites, and people expect it to be there. I agree with this, we should aim for the 80% use case.

So I think for the case of Drush the way forward is quite clear, it should remain in require. Drupal-console is still under discussion in #352.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants