Issue #2348185 by p-neyens, drunken monkey: Renamed "Filters" to "Processors" in the UI.

Author: p-neyens

Diff for: js/index-active-formatters.js

@@ -1,6 +1,6 @@
 /**
  * @file
- * Attaches show/hide functionality to processor checkboxes in "Filters" tabs.
+ * Attaches show/hide functionality to checkboxes in the "Processor" tab.
  */
 
 (function ($) {
@@ -17,7 +17,7 @@
         var tab = $('.search-api-processor-settings-' + processor_id, context).data('verticalTab');
 
         // Bind a click handler to this checkbox to conditionally show and hide
-        // the filter's table row and vertical tab pane.
+        // the processor's table row and vertical tab pane.
         $checkbox.on('click.searchApiUpdate', function () {
           if ($checkbox.is(':checked')) {
             $rows.show();

Diff for: search_api.links.task.yml

@@ -20,8 +20,8 @@ entity.search_api_index.fields:
   route_name: entity.search_api_index.fields
   base_route: entity.search_api_index.canonical
   weight: 10
-entity.search_api_index.filters:
-  route_name: entity.search_api_index.filters
+entity.search_api_index.processors:
+  route_name: entity.search_api_index.processors
   base_route: entity.search_api_index.canonical
-  title: 'Filters'
+  title: 'Processors'
   weight: 20

Diff for: search_api.routing.yml

@@ -109,12 +109,12 @@ entity.search_api_index.fields:
   requirements:
     _entity_access: 'search_api_index.fields'
 
-entity.search_api_index.filters:
-  path: '/admin/config/search/search-api/index/{search_api_index}/filters'
+entity.search_api_index.processors:
+  path: '/admin/config/search/search-api/index/{search_api_index}/processors'
   defaults:
-    _entity_form: 'search_api_index.filters'
+    _entity_form: 'search_api_index.processors'
   requirements:
-    _entity_access: 'search_api_index.filters'
+    _entity_access: 'search_api_index.processors'
 
 entity.search_api_index.reindex:
   path: '/admin/config/search/search-api/index/{search_api_index}/reindex'

Diff for: search_api.theme.inc

@@ -254,7 +254,7 @@ function theme_search_api_index($variables) {
       $info = t('Invalid or missing datasource plugin: %datasource_id', array('%datasource_id' => $datasource_id));
     }
     // Append the row and reset variables.
-    $label = t('Data sources');
+    $label = t('Data source');
     $rows[] = Utility::deepCopy($row);
     $class = '';
   }

Diff for: src/Entity/Index.php

@@ -38,7 +38,7 @@
  *       "default" = "Drupal\search_api\Form\IndexForm",
  *       "edit" = "Drupal\search_api\Form\IndexForm",
  *       "fields" = "Drupal\search_api\Form\IndexFieldsForm",
- *       "filters" = "Drupal\search_api\Form\IndexFiltersForm",
+ *       "processors" = "Drupal\search_api\Form\IndexProcessorsForm",
  *       "delete" = "Drupal\search_api\Form\IndexDeleteConfirmForm",
  *       "disable" = "Drupal\search_api\Form\IndexDisableConfirmForm",
  *       "reindex" = "Drupal\search_api\Form\IndexReindexConfirmForm",
@@ -58,7 +58,7 @@
  *     "add-form" = "/admin/config/search/search-api/add-index",
  *     "edit-form" = "/admin/config/search/search-api/index/{search_api_index}/edit",
  *     "fields" = "/admin/config/search/search-api/index/{search_api_index}/fields",
- *     "filters" = "/admin/config/search/search-api/index/{search_api_index}/filters",
+ *     "processors" = "/admin/config/search/search-api/index/{search_api_index}/processors",
  *     "delete-form" = "/admin/config/search/search-api/index/{search_api_index}/delete",
  *     "disable" = "/admin/config/search/search-api/index/{search_api_index}/disable",
  *     "enable" = "/admin/config/search/search-api/index/{search_api_index}/enable",

Diff for: src/Form/IndexForm.php

@@ -219,8 +219,8 @@ public function buildEntityForm(array &$form, FormStateInterface $form_state, In
     }
     $form['datasources'] = array(
       '#type' => 'select',
-      '#title' => $this->t('Data types'),
-      '#description' => $this->t('Select one or more data type of items that will be stored in this index.'),
+      '#title' => $this->t('Data sources'),
+      '#description' => $this->t('Select one or more data sources of items that will be stored in this index.'),
       '#options' => $datasource_options,
       '#default_value' => $index->getDatasourceIds(),
       '#multiple' => TRUE,

Diff for: src/Form/IndexFiltersForm.php renamed to src/Form/IndexProcessorsForm.php

@@ -2,7 +2,7 @@
 
 /**
  * @file
- * Contains \Drupal\search_api\Form\IndexFiltersForm.
+ * Contains \Drupal\search_api\Form\IndexProcessorsForm.
  */
 
 namespace Drupal\search_api\Form;
@@ -19,7 +19,7 @@
 /**
  * Provides a form for configuring the processors of a search index.
  */
-class IndexFiltersForm extends EntityForm {
+class IndexProcessorsForm extends EntityForm {
 
   /**
    * The index being configured.
@@ -43,7 +43,7 @@ class IndexFiltersForm extends EntityForm {
   protected $processorPluginManager;
 
   /**
-   * Constructs an IndexFiltersForm object.
+   * Constructs an IndexProcessorsForm.
    *
    * @param \Drupal\Core\Entity\EntityManagerInterface $entity_manager
    *   The entity manager.
@@ -101,7 +101,7 @@ public function form(array $form, FormStateInterface $form_state) {
 
     $form['#tree'] = TRUE;
     $form['#attached']['library'][] = 'search_api/drupal.search_api.index-active-formatters';
-    $form['#title'] = $this->t('Manage filters for search index %label', array('%label' => $this->entity->label()));
+    $form['#title'] = $this->t('Manage processors for search index %label', array('%label' => $this->entity->label()));
     $form['description']['#markup'] = '<p>' . $this->t('Configure processors which will pre- and post-process data at index and search time.') . '</p>';
 
     // Add the list of processors with checkboxes to enable/disable them.

Diff for: src/IndexListBuilder.php

@@ -68,10 +68,10 @@ public function getDefaultOperations(EntityInterface $entity) {
         'weight' => 20,
         'url' => new Url('entity.search_api_index.fields', $route_parameters),
       );
-      $operations['filters'] = array(
-        'title' => $this->t('Filters'),
+      $operations['processors'] = array(
+        'title' => $this->t('Processors'),
         'weight' => 30,
-        'url' => new Url('entity.search_api_index.filters', $route_parameters),
+        'url' => new Url('entity.search_api_index.processors', $route_parameters),
       );
     }
 

Diff for: src/Tests/IntegrationTest.php

@@ -128,7 +128,7 @@ protected function createIndex() {
     $this->drupalPostForm(NULL, $edit, $this->t('Save'));
     $this->assertText($this->t('!name field is required.', array('!name' => $this->t('Index name'))));
     $this->assertText($this->t('!name field is required.', array('!name' => $this->t('Machine-readable name'))));
-    $this->assertText($this->t('!name field is required.', array('!name' => $this->t('Data types'))));
+    $this->assertText($this->t('!name field is required.', array('!name' => $this->t('Data sources'))));
 
     $this->indexId = 'test_index';
 
@@ -374,7 +374,7 @@ protected function addFilter() {
     $edit = array(
       'status[ignorecase]' => 1,
     );
-    $this->drupalPostForm($this->getIndexPath('filters'), $edit, $this->t('Save'));
+    $this->drupalPostForm($this->getIndexPath('processors'), $edit, $this->t('Save'));
     /** @var \Drupal\search_api\IndexInterface $index */
     $index = entity_load('search_api_index', $this->indexId, TRUE);
     $processors = $index->getProcessors();
@@ -390,7 +390,7 @@ protected function configureFilter() {
       'processors[ignorecase][settings][fields][search_api_language]' => FALSE,
       'processors[ignorecase][settings][fields][entity:node/title]' => 'entity:node/title',
     );
-    $this->drupalPostForm($this->getIndexPath('filters'), $edit, $this->t('Save'));
+    $this->drupalPostForm($this->getIndexPath('processors'), $edit, $this->t('Save'));
     /** @var \Drupal\search_api\IndexInterface $index */
     $index = entity_load('search_api_index', $this->indexId, TRUE);
     $processors = $index->getProcessors();

Diff for: src/Tests/Processor/ProcessorIntegrationTest.php

@@ -215,7 +215,7 @@ public function checkUrlFieldIntegration() {
    *   The ID of the processor to enable.
    */
   protected function enableProcessor($processor_id) {
-    $this->loadFiltersTab();
+    $this->loadProcessorsTab();
 
     $edit = array(
       "status[$processor_id]" => 1,
@@ -234,7 +234,7 @@ protected function enableProcessor($processor_id) {
    *   The ID of the processor whose settings are edited.
    */
   protected function editSettingsForm($edit, $processor_id) {
-    $this->loadFiltersTab();
+    $this->loadProcessorsTab();
 
     $this->drupalPostForm(NULL, $edit, $this->t('Save'));
 
@@ -252,10 +252,10 @@ protected function editSettingsForm($edit, $processor_id) {
   }
 
   /**
-   * Loads the test index's "Filters" tab in the test browser, if necessary.
+   * Loads the test index's "Processors" tab in the test browser, if necessary.
    */
-  protected function loadFiltersTab() {
-    $settings_path = 'admin/config/search/search-api/index/' . $this->indexId . '/filters';
+  protected function loadProcessorsTab() {
+    $settings_path = 'admin/config/search/search-api/index/' . $this->indexId . '/processors';
     if ($this->getAbsoluteUrl($settings_path) != $this->getUrl()) {
       $this->drupalGet($settings_path);
     }