Issue #2867118 by drunken monkey: Fixed reported coding standards problems.

Author: drunken-monkey

Diff for: CHANGELOG.txt

@@ -1,5 +1,6 @@
 Search API 1.x, dev (xxxx-xx-xx):
 ---------------------------------
+- #2867118 by drunken monkey: Fixed reported coding standards problems.
 - #2839932 by drunken monkey,  borisson_, bmcclure, jacktonkin: Fixed Views
   problems with "Rendered item" fields.
 - #2765317 by vasike: Added a "Last" aggregation for aggregated fields.

Diff for: js/search_api.processors.js

@@ -5,7 +5,7 @@
 
 (function ($) {
 
-  "use strict";
+  'use strict';
 
   Drupal.behaviors.searchApiProcessor = {
     attach: function (context, settings) {

Diff for: modules/search_api_db/search_api_db_defaults/tests/src/Functional/IntegrationTest.php

@@ -61,7 +61,7 @@ public function testInstallAndDefaultSetupWorking() {
     \Drupal::state()->set('search_api_use_tracking_batch', FALSE);
 
     // Install the search_api_db_defaults module.
-    if (version_compare(\Drupal::VERSION, '8.3', '>=')){
+    if (version_compare(\Drupal::VERSION, '8.3', '>=')) {
       $edit_enable = [
         'modules[search_api_db_defaults][enable]' => TRUE,
       ];

Diff for: modules/search_api_db/src/Plugin/search_api/backend/Database.php

@@ -28,7 +28,6 @@
 use Drupal\search_api\Query\QueryInterface;
 use Drupal\search_api\SearchApiException;
 use Drupal\search_api\Utility\DataTypeHelper;
-use Drupal\search_api\Utility\Utility;
 use Drupal\search_api_autocomplete\Entity\SearchApiAutocompleteSearch;
 use Drupal\search_api_autocomplete\Suggestion;
 use Drupal\search_api_db\DatabaseCompatibility\DatabaseCompatibilityHandlerInterface;

Diff for: src/Form/IndexForm.php

@@ -11,7 +11,6 @@
 use Drupal\Core\Utility\Error;
 use Drupal\search_api\IndexInterface;
 use Drupal\search_api\SearchApiException;
-use Drupal\search_api\Tracker\TrackerPluginManager;
 use Drupal\search_api\Utility\PluginHelperInterface;
 use Symfony\Component\DependencyInjection\ContainerInterface;
 
@@ -118,6 +117,10 @@ public function form(array $form, FormStateInterface $form_state) {
   /**
    * Builds the form for the basic index properties.
    *
+   * @param array $form
+   *   The current form array.
+   * @param \Drupal\Core\Form\FormStateInterface $form_state
+   *   The current form state.
    * @param \Drupal\search_api\IndexInterface $index
    *   The index that is being created or edited.
    */
@@ -306,6 +309,10 @@ public function buildEntityForm(array &$form, FormStateInterface $form_state, In
   /**
    * Builds the configuration forms for all selected datasources.
    *
+   * @param array $form
+   *   The current form array.
+   * @param \Drupal\Core\Form\FormStateInterface $form_state
+   *   The current form state.
    * @param \Drupal\search_api\IndexInterface $index
    *   The index being created or edited.
    */
@@ -352,6 +359,10 @@ public function buildDatasourcesConfigForm(array &$form, FormStateInterface $for
   /**
    * Builds the tracker configuration form.
    *
+   * @param array $form
+   *   The current form array.
+   * @param \Drupal\Core\Form\FormStateInterface $form_state
+   *   The current form state.
    * @param \Drupal\search_api\IndexInterface $index
    *   The index being created or edited.
    */
@@ -404,6 +415,11 @@ public function buildTrackerConfigForm(array &$form, FormStateInterface $form_st
    * Form submission handler for buildEntityForm().
    *
    * Takes care of changes in the selected datasources.
+   *
+   * @param array $form
+   *   The current form array.
+   * @param \Drupal\Core\Form\FormStateInterface $form_state
+   *   The current form state.
    */
   public function submitAjaxDatasourceConfigForm($form, FormStateInterface $form_state) {
     $form_state->setValue('id', NULL);
@@ -412,6 +428,14 @@ public function submitAjaxDatasourceConfigForm($form, FormStateInterface $form_s
 
   /**
    * Handles changes to the selected datasources.
+   *
+   * @param array $form
+   *   The current form array.
+   * @param \Drupal\Core\Form\FormStateInterface $form_state
+   *   The current form state.
+   *
+   * @return array
+   *   The part of the form to return as AJAX.
    */
   public function buildAjaxDatasourceConfigForm(array $form, FormStateInterface $form_state) {
     return $form['datasource_configs'];
@@ -421,6 +445,11 @@ public function buildAjaxDatasourceConfigForm(array $form, FormStateInterface $f
    * Form submission handler for buildEntityForm().
    *
    * Takes care of changes in the selected tracker plugin.
+   *
+   * @param array $form
+   *   The current form array.
+   * @param \Drupal\Core\Form\FormStateInterface $form_state
+   *   The current form state.
    */
   public function submitAjaxTrackerConfigForm(array $form, FormStateInterface $form_state) {
     $form_state->setValue('id', NULL);
@@ -429,6 +458,14 @@ public function submitAjaxTrackerConfigForm(array $form, FormStateInterface $for
 
   /**
    * Handles switching the selected tracker plugin.
+   *
+   * @param array $form
+   *   The current form array.
+   * @param \Drupal\Core\Form\FormStateInterface $form_state
+   *   The current form state.
+   *
+   * @return array
+   *   The part of the form to return as AJAX.
    */
   public function buildAjaxTrackerConfigForm(array $form, FormStateInterface $form_state) {
     return $form['tracker_config'];

Diff for: src/Form/ServerForm.php

@@ -94,6 +94,10 @@ public function form(array $form, FormStateInterface $form_state) {
   /**
    * Builds the form for the basic server properties.
    *
+   * @param array $form
+   *   The current form array.
+   * @param \Drupal\Core\Form\FormStateInterface $form_state
+   *   The current form state.
    * @param \Drupal\search_api\ServerInterface $server
    *   The server that is being created or edited.
    */
@@ -173,6 +177,10 @@ public function buildEntityForm(array &$form, FormStateInterface $form_state, Se
   /**
    * Builds the backend-specific configuration form.
    *
+   * @param array $form
+   *   The current form array.
+   * @param \Drupal\Core\Form\FormStateInterface $form_state
+   *   The current form state.
    * @param \Drupal\search_api\ServerInterface $server
    *   The server that is being created or edited.
    */
@@ -210,6 +218,14 @@ public function buildBackendConfigForm(array &$form, FormStateInterface $form_st
 
   /**
    * Handles switching the selected backend plugin.
+   *
+   * @param array $form
+   *   The current form array.
+   * @param \Drupal\Core\Form\FormStateInterface $form_state
+   *   The current form state.
+   *
+   * @return array
+   *   The part of the form to return as AJAX.
    */
   public static function buildAjaxBackendConfigForm(array $form, FormStateInterface $form_state) {
     // The work is already done in form(), where we rebuild the entity according
@@ -296,11 +312,4 @@ public function save(array $form, FormStateInterface $form_state) {
     }
   }
 
-  /**
-   * {@inheritdoc}
-   */
-  public function delete(array $form, FormStateInterface $form_state) {
-    $form_state->setRedirect('search_api.server_delete', array('search_api_server' => $this->getEntity()->id()));
-  }
-
 }

Diff for: src/Plugin/search_api/processor/Highlight.php

@@ -12,7 +12,6 @@
 use Drupal\search_api\Query\QueryInterface;
 use Drupal\search_api\Query\ResultSetInterface;
 use Drupal\search_api\Utility\DataTypeHelperInterface;
-use Drupal\search_api\Utility\Utility;
 
 /**
  * Adds a highlighted excerpt to results and highlights returned fields.

Diff for: tests/search_api_test_hooks/search_api_test_hooks.search_api.inc

@@ -9,7 +9,6 @@ use Drupal\search_api\IndexInterface;
 use Drupal\search_api\Query\QueryInterface;
 use Drupal\search_api\Query\ResultSetInterface;
 use Drupal\search_api\ServerInterface;
-use Drupal\search_api\Utility\Utility;
 
 /**
  * Implements hook_search_api_backend_info_alter().