Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit code should not be zero if there is an error applying patches #143

Closed
Livven opened this issue Jun 1, 2019 · 2 comments
Closed

Exit code should not be zero if there is an error applying patches #143

Livven opened this issue Jun 1, 2019 · 2 comments

Comments

@Livven
Copy link

Livven commented Jun 1, 2019

Thoughts? Seems kinda dangerous e.g. if a package is updated and a patch fails to apply, but if you don't pay attention to the CLI output you will never know.

@ds300
Copy link
Owner

ds300 commented Jun 6, 2019

Hi! The exit code is 1 on CI but 0 at dev time to work around some odd behaviour of yarn's. see #86

@Livven
Copy link
Author

Livven commented Jun 8, 2019

Oh that's cool then. Might still be useful to have an option to force the non-zero exit code but this is fine by me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants