Skip to content

Commit 702d8c1

Browse files
bk2204ttaylorr
authored andcommitted
Require Perl 5.26.0
Our platform support policy states that we require "versions of dependencies which are generally accepted as stable and supportable, e.g., in line with the version used by other long-term-support distributions". Of Debian, Ubuntu, RHEL, and SLES, the four most common distributions that provide LTS versions, the version with mainstream long-term security support with the oldest Perl is 5.26.0 in SLES 15.6. This is a major upgrade, since Perl 5.8.1, according to the Perl documentation, was released in September of 2003. It brings a lot of new features that we can choose to use, such as s///r to return the modified string, the postderef functionality, and subroutine signatures, although the latter was still considered experimental until 5.36. This change was made with the following one-liner, which intentionally excludes modifying the vendored modules we include to avoid conflicts: git grep -l 'use 5.008001' | grep -v 'LoadCPAN/' | xargs perl -pi -e 's/use 5.008001/require v5.26/' Use require instead of use to avoid changing the behavior as the latter enables features and the former does not. Signed-off-by: brian m. carlson <[email protected]> Signed-off-by: Taylor Blau <[email protected]>
1 parent 7bae4e7 commit 702d8c1

18 files changed

+18
-18
lines changed

INSTALL

+1-1
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ Issues of note:
119119
- A POSIX-compliant shell is required to run some scripts needed
120120
for everyday use (e.g. "bisect", "request-pull").
121121

122-
- "Perl" version 5.8.1 or later is needed to use some of the
122+
- "Perl" version 5.26.0 or later is needed to use some of the
123123
features (e.g. sending patches using "git send-email",
124124
interacting with svn repositories with "git svn"). If you can
125125
live without these, use NO_PERL. Note that recent releases of

contrib/diff-highlight/DiffHighlight.pm

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package DiffHighlight;
22

3-
use 5.008001;
3+
require v5.26;
44
use warnings FATAL => 'all';
55
use strict;
66

contrib/mw-to-git/Git/Mediawiki.pm

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package Git::Mediawiki;
22

3-
use 5.008001;
3+
require v5.26;
44
use strict;
55
use POSIX;
66
use Git;

git-archimport.perl

+1-1
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ =head1 Devel Notes
5454
5555
=cut
5656

57-
use 5.008001;
57+
require v5.26;
5858
use strict;
5959
use warnings;
6060
use Getopt::Std;

git-cvsexportcommit.perl

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#!/usr/bin/perl
22

3-
use 5.008001;
3+
require v5.26;
44
use strict;
55
use warnings;
66
use Getopt::Std;

git-cvsimport.perl

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
# The head revision is on branch "origin" by default.
1414
# You can change that with the '-o' option.
1515

16-
use 5.008001;
16+
require v5.26;
1717
use strict;
1818
use warnings;
1919
use Getopt::Long;

git-cvsserver.perl

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
####
1616
####
1717

18-
use 5.008001;
18+
require v5.26;
1919
use strict;
2020
use warnings;
2121
use bytes;

git-send-email.perl

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
# and second line is the subject of the message.
1717
#
1818

19-
use 5.008001;
19+
require v5.26;
2020
use strict;
2121
use warnings $ENV{GIT_PERL_FATAL_WARNINGS} ? qw(FATAL all) : ();
2222
use Getopt::Long;

git-svn.perl

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
#!/usr/bin/perl
22
# Copyright (C) 2006, Eric Wong <[email protected]>
33
# License: GPL v2 or later
4-
use 5.008001;
4+
require v5.26;
55
use warnings $ENV{GIT_PERL_FATAL_WARNINGS} ? qw(FATAL all) : ();
66
use strict;
77
use vars qw/ $AUTHOR $VERSION

gitweb/gitweb.perl

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
#
88
# This program is licensed under the GPLv2
99

10-
use 5.008001;
10+
require v5.26;
1111
use strict;
1212
use warnings;
1313
# handle ACL in file access tests

perl/Git.pm

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ Git - Perl interface to the Git version control system
77

88
package Git;
99

10-
use 5.008001;
10+
require v5.26;
1111
use strict;
1212
use warnings $ENV{GIT_PERL_FATAL_WARNINGS} ? qw(FATAL all) : ();
1313

perl/Git/I18N.pm

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
package Git::I18N;
2-
use 5.008001;
2+
require v5.26;
33
use strict;
44
use warnings $ENV{GIT_PERL_FATAL_WARNINGS} ? qw(FATAL all) : ();
55
BEGIN {

perl/Git/LoadCPAN.pm

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
package Git::LoadCPAN;
2-
use 5.008001;
2+
require v5.26;
33
use strict;
44
use warnings $ENV{GIT_PERL_FATAL_WARNINGS} ? qw(FATAL all) : ();
55

perl/Git/Packet.pm

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
package Git::Packet;
2-
use 5.008001;
2+
require v5.26;
33
use strict;
44
use warnings $ENV{GIT_PERL_FATAL_WARNINGS} ? qw(FATAL all) : ();
55
BEGIN {

t/t0202/test.pl

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#!/usr/bin/perl
2-
use 5.008001;
2+
require v5.26;
33
use lib (split(/:/, $ENV{GITPERLLIB}));
44
use strict;
55
use warnings;

t/t5562/invoke-with-content-length.pl

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
use 5.008001;
1+
require v5.26;
22
use strict;
33
use warnings;
44

t/t9700/test.pl

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
#!/usr/bin/perl
22
use lib (split(/:/, $ENV{GITPERLLIB}));
33

4-
use 5.008001;
4+
require v5.26;
55
use warnings;
66
use strict;
77

t/test-terminal.perl

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#!/usr/bin/perl
2-
use 5.008001;
2+
require v5.26;
33
use strict;
44
use warnings;
55
use IO::Pty;

0 commit comments

Comments
 (0)