fix: ignore packet received after disconnection

Related: socketio#3095

Author: darrachequesne

lib/socket.ts

@@ -537,7 +537,11 @@ export class Socket extends EventEmitter {
         if (err) {
           return this._onerror(err);
         }
-        super.emit.apply(this, event);
+        if (this.connected) {
+          super.emit.apply(this, event);
+        } else {
+          debug("ignore packet received after disconnection");
+        }
       });
     });
   }

test/socket.io.ts

@@ -1787,6 +1787,33 @@ describe("socket.io", () => {
       });
     });
 
+    it("should ignore a packet received after disconnection", (done) => {
+      const srv = createServer();
+      const sio = new Server(srv);
+
+      srv.listen(() => {
+        const clientSocket = client(srv);
+
+        const success = () => {
+          clientSocket.close();
+          sio.close();
+          done();
+        };
+
+        sio.on("connection", (socket) => {
+          socket.on("test", () => {
+            done(new Error("should not happen"));
+          });
+          socket.on("disconnect", success);
+        });
+
+        clientSocket.on("connect", () => {
+          clientSocket.emit("test", Buffer.alloc(10));
+          clientSocket.disconnect();
+        });
+      });
+    });
+
     describe("onAny", () => {
       it("should call listener", (done) => {
         const srv = createServer();