Skip to content

Commit a5d7c0a

Browse files
bjacobelbjacobel
authored
Make entire repo pass ESLint (#344)
1 parent 2fbaf62 commit a5d7c0a

28 files changed

+357
-344
lines changed

‎.eslintignore

+2
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
11
_preview_site
22
_site
33
node_modules
4+
!pldoc/_includes/examples
5+
pldoc/public

‎gulp/.eslintrc.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
{
22
"rules": {
3-
"no-console": "off"
3+
"no-console": "off",
4+
"strict": ["error", "global"]
45
}
5-
}
6+
}

‎gulp/config.js

+58-56
Original file line numberDiff line numberDiff line change
@@ -1,102 +1,104 @@
11
// gulp pattern library + site configuration
22

3+
'use strict';
4+
35
// pattern library
4-
var patternLibrarySrc = './pattern-library',
5-
local = './_site',
6+
var patternLibrarySrc = './pattern-library',
7+
local = './_site',
68

79
// documentation site
8-
pldocSrc = './pldoc',
9-
pldocDest = pldocSrc + '/public',
10+
pldocSrc = './pldoc',
11+
pldocDest = pldocSrc + '/public',
1012

1113
// example demo
12-
demoSrc = './demo';
14+
demoSrc = './demo';
1315

1416
module.exports = {
1517
patternLibrary: {
16-
src_files: patternLibrarySrc + '/**/*',
18+
src_files: patternLibrarySrc + '/**/*',
1719
src: patternLibrarySrc,
1820
dest: pldocDest + '/edx-pattern-library'
1921
},
20-
browserSync: {
21-
server: {
22+
browserSync: {
23+
server: {
2224
// Serve up our build folder
23-
baseDir: local
25+
baseDir: local
2426
}
2527
},
26-
styles: {
28+
styles: {
2729
// pattern library
28-
rootLtrSassFile: patternLibrarySrc + '/sass/edx-pattern-library-ltr.scss',
29-
rootRtlSassFile: patternLibrarySrc + '/sass/edx-pattern-library-rtl.scss',
30-
src: patternLibrarySrc + '/sass',
31-
dest: patternLibrarySrc + '/css',
32-
dest_files: patternLibrarySrc + '/css/**/*.css',
30+
rootLtrSassFile: patternLibrarySrc + '/sass/edx-pattern-library-ltr.scss',
31+
rootRtlSassFile: patternLibrarySrc + '/sass/edx-pattern-library-rtl.scss',
32+
src: patternLibrarySrc + '/sass',
33+
dest: patternLibrarySrc + '/css',
34+
dest_files: patternLibrarySrc + '/css/**/*.css',
3335

3436
// documentation site
35-
pldoc_src: pldocSrc + '/static/sass',
36-
pldoc_src_files: pldocSrc + '/static/sass/**/*.scss',
37+
pldoc_src: pldocSrc + '/static/sass',
38+
pldoc_src_files: pldocSrc + '/static/sass/**/*.scss',
3739

3840
// example demo
39-
demo_src: demoSrc + '/static/sass',
40-
demo_src_files: demoSrc + '/static/sass/**/*.scss'
41+
demo_src: demoSrc + '/static/sass',
42+
demo_src_files: demoSrc + '/static/sass/**/*.scss'
4143
},
42-
fonts: {
44+
fonts: {
4345
// pattern library
44-
src: patternLibrarySrc + '/fonts',
45-
src_files: patternLibrarySrc + '/fonts/**/*',
46-
dest: pldocDest + '/fonts',
46+
src: patternLibrarySrc + '/fonts',
47+
src_files: patternLibrarySrc + '/fonts/**/*',
48+
dest: pldocDest + '/fonts',
4749

4850
// documentation site
49-
pldoc_src: pldocSrc + '/static/fonts',
50-
pldoc_src_files: pldocSrc + '/static/fonts/**/*',
51+
pldoc_src: pldocSrc + '/static/fonts',
52+
pldoc_src_files: pldocSrc + '/static/fonts/**/*',
5153

5254
// example demo
53-
demo_src: demoSrc + '/static/fonts',
54-
demo_src_files: demoSrc + '/static/fonts/**/*'
55+
demo_src: demoSrc + '/static/fonts',
56+
demo_src_files: demoSrc + '/static/fonts/**/*'
5557
},
56-
images: {
58+
images: {
5759
// pattern library
58-
src: patternLibrarySrc + '/images',
59-
src_files: patternLibrarySrc + '/images/**/*',
60-
dest: pldocDest + '/images',
60+
src: patternLibrarySrc + '/images',
61+
src_files: patternLibrarySrc + '/images/**/*',
62+
dest: pldocDest + '/images',
6163

6264
// documentation site
63-
pldoc_src: pldocSrc + '/static/images',
64-
pldoc_src_files: pldocSrc + '/static/images/**/*',
65+
pldoc_src: pldocSrc + '/static/images',
66+
pldoc_src_files: pldocSrc + '/static/images/**/*',
6567

6668
// example demo
67-
demo_src: demoSrc + '/static/images',
68-
demo_src_files: demoSrc + '/static/images/**/*'
69+
demo_src: demoSrc + '/static/images',
70+
demo_src_files: demoSrc + '/static/images/**/*'
6971
},
70-
scripts: {
72+
scripts: {
7173
// pattern library
72-
src: patternLibrarySrc + '/js',
73-
src_files: patternLibrarySrc + '/js/**/*.js',
74-
dest: pldocDest + '/js',
74+
src: patternLibrarySrc + '/js',
75+
src_files: patternLibrarySrc + '/js/**/*.js',
76+
dest: pldocDest + '/js',
7577

7678
// documentation site
77-
pldoc_src: pldocSrc + '/static/js',
78-
pldoc_src_files: pldocSrc + '/static/js/**/*.js',
79+
pldoc_src: pldocSrc + '/static/js',
80+
pldoc_src_files: pldocSrc + '/static/js/**/*.js',
7981

8082
// example demo
81-
demo_src: demoSrc + '/static/js',
82-
demo_src_files: demoSrc + '/static/js/**/*.js'
83+
demo_src: demoSrc + '/static/js',
84+
demo_src_files: demoSrc + '/static/js/**/*.js'
8385
},
84-
exampleHtmlFiles: {
85-
pldoc_src_files: pldocSrc + '/_includes/examples/*.html'
86+
exampleHtmlFiles: {
87+
pldoc_src_files: pldocSrc + '/_includes/examples/*.html'
8688
},
87-
lib: {
89+
lib: {
8890
// third party libraries
89-
src: './node_modules'
91+
src: './node_modules'
9092
},
91-
jekyll: {
92-
home: './pldoc/index.html',
93-
posts: './pldoc/_posts/**/*',
94-
components: './pldoc/_components/**/*',
95-
design_elements: './pldoc/_design_elements/**/*',
96-
includes: './pldoc/_includes/**/*',
97-
examples: './pldoc/examples/**/*',
98-
demo: './pldoc/demo/**/*.html',
99-
layouts: './pldoc/_layouts/**/*'
93+
jekyll: {
94+
home: './pldoc/index.html',
95+
posts: './pldoc/_posts/**/*',
96+
components: './pldoc/_components/**/*',
97+
design_elements: './pldoc/_design_elements/**/*',
98+
includes: './pldoc/_includes/**/*',
99+
examples: './pldoc/examples/**/*',
100+
demo: './pldoc/demo/**/*.html',
101+
layouts: './pldoc/_layouts/**/*'
100102
},
101103
documentation: {
102104
rootJavaScriptFile: './pldoc/static/js/pattern-library-doc.js',

‎gulp/tasks/browserSync.js

+5-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
1-
var gulp = require('gulp'),
2-
browserSync = require('browser-sync'),
3-
config = require('../config').browserSync;
1+
'use strict';
2+
3+
var gulp = require('gulp'),
4+
browserSync = require('browser-sync'),
5+
config = require('../config').browserSync;
46

57
gulp.task('browserSync', ['jekyll-build'], function() {
68
browserSync(config);

‎gulp/tasks/build-development.js

+16-18
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,18 @@
1-
(function() {
2-
'use strict';
1+
'use strict';
32

4-
var gulp = require('gulp'),
5-
runSequence = require('run-sequence');
3+
var gulp = require('gulp'),
4+
runSequence = require('run-sequence');
65

7-
gulp.task('build-development', function(callback) {
8-
runSequence(
9-
'fonts',
10-
'images',
11-
'scripts',
12-
'pldoc-scripts',
13-
'demo-scripts',
14-
'demo-styles',
15-
'copy-pattern-library',
16-
'webpack',
17-
callback
18-
);
19-
});
20-
})();
6+
gulp.task('build-development', function(callback) {
7+
runSequence(
8+
'fonts',
9+
'images',
10+
'scripts',
11+
'pldoc-scripts',
12+
'demo-scripts',
13+
'demo-styles',
14+
'copy-pattern-library',
15+
'webpack',
16+
callback
17+
);
18+
});

‎gulp/tasks/build-production.js

+12-13
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,14 @@
1-
(function() {
2-
'use strict';
1+
'use strict';
32

4-
var gulp = require('gulp'),
5-
runSequence = require('run-sequence');
3+
var gulp = require('gulp'),
4+
runSequence = require('run-sequence');
65

7-
gulp.task('build-production', function(callback) {
8-
runSequence(
9-
'clean',
10-
'build-development',
11-
'scripts-uglify',
12-
'webpack',
13-
callback);
14-
});
15-
})();
6+
gulp.task('build-production', function(callback) {
7+
runSequence(
8+
'clean',
9+
'build-development',
10+
'scripts-uglify',
11+
'webpack',
12+
callback
13+
);
14+
});

‎gulp/tasks/clean.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
'use strict';
22

3-
var gulp = require('gulp'),
4-
config = require('../config'),
5-
del = require('del');
3+
var gulp = require('gulp'),
4+
config = require('../config'),
5+
del = require('del');
66

77
gulp.task('clean', function() {
88
return del([

‎gulp/tasks/default.js

+4-3
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
11
'use strict';
22

3-
var gulp = require('gulp'),
4-
runSequence = require('run-sequence');
3+
var gulp = require('gulp'),
4+
runSequence = require('run-sequence');
55

66
gulp.task('default', function(cb) {
77
runSequence(
88
'build-development',
99
'watch',
10-
cb);
10+
cb
11+
);
1112
});

‎gulp/tasks/demo_scripts.js

+10-11
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,15 @@
11
'use strict';
22

3-
var gulp = require('gulp'),
4-
browserSync = require('browser-sync'),
5-
config = require('../config').scripts,
6-
uglify = require('gulp-uglify');
3+
var gulp = require('gulp'),
4+
browserSync = require('browser-sync'),
5+
config = require('../config').scripts,
6+
uglify = require('gulp-uglify');
77

8-
gulp.task('demo-scripts', ['lint'], function() {
8+
gulp.task('demo-scripts', ['lint-src'], function() {
99
return gulp.src([
10-
// setup script sequence
11-
config.demo_src + '/pattern-library.js'
12-
])
13-
.pipe(uglify())
14-
.pipe(browserSync.reload({stream: true}))
15-
.pipe(gulp.dest(config.dest));
10+
// setup script sequence
11+
config.demo_src + '/pattern-library.js'
12+
]).pipe(uglify())
13+
.pipe(browserSync.reload({stream: true}))
14+
.pipe(gulp.dest(config.dest));
1615
});

‎gulp/tasks/demo_styles.js

+5-7
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,9 @@ var gulp = require('gulp'),
66
webpackUtil = require('../util/webpack');
77

88
gulp.task('demo-styles', function() {
9-
return webpackUtil.packageCss(
10-
{
11-
source: config.documentation.rootDemoSassFile,
12-
targetDirectory: config.documentation.pldocDest,
13-
patternLibraryPath: '/public/edx-pattern-library'
14-
})
15-
.pipe(browserSync.stream());
9+
return webpackUtil.packageCss({
10+
source: config.documentation.rootDemoSassFile,
11+
targetDirectory: config.documentation.pldocDest,
12+
patternLibraryPath: '/public/edx-pattern-library'
13+
}).pipe(browserSync.stream());
1614
});

‎gulp/tasks/fonts.js

+5-6
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,12 @@
11
'use strict';
22

3-
var gulp = require('gulp'),
4-
browserSync = require('browser-sync'),
5-
changed = require('gulp-changed'),
6-
config = require('../config').fonts,
7-
merge = require('merge-stream');
3+
var gulp = require('gulp'),
4+
browserSync = require('browser-sync'),
5+
changed = require('gulp-changed'),
6+
config = require('../config').fonts,
7+
merge = require('merge-stream');
88

99
gulp.task('fonts', function() {
10-
1110
var fonts = gulp.src(config.src_files),
1211
pldocFonts = gulp.src(config.pldoc_src_files),
1312
demoFonts = gulp.src(config.demo_src_files);

‎gulp/tasks/images.js

+5-6
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,12 @@
11
'use strict';
22

3-
var gulp = require('gulp'),
4-
browserSync = require('browser-sync'),
5-
changed = require('gulp-changed'),
6-
config = require('../config').images,
7-
merge = require('merge-stream');
3+
var gulp = require('gulp'),
4+
browserSync = require('browser-sync'),
5+
changed = require('gulp-changed'),
6+
config = require('../config').images,
7+
merge = require('merge-stream');
88

99
gulp.task('images', function() {
10-
1110
var images = gulp.src(config.src_files),
1211
pldocImages = gulp.src(config.pldoc_src_files),
1312
demoImages = gulp.src(config.demo_src_files);

‎gulp/tasks/jekyll-build.js

+5-4
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
1-
var gulp = require('gulp'),
2-
config = require('../config').jekyll,
3-
cp = require('child_process');
1+
'use strict';
42

5-
gulp.task('jekyll-build', function (done) {
3+
var gulp = require('gulp'),
4+
cp = require('child_process');
5+
6+
gulp.task('jekyll-build', function(done) {
67
return cp.spawn('jekyll', ['build'], {stdio: 'inherit'})
78
.on('close', done);
89
});

‎gulp/tasks/jekyll-rebuild.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
var gulp = require('gulp'),
2-
browserSync = require('browser-sync'),
3-
config = require('../config').jekyll,
4-
cp = require('child_process');
1+
'use strict';
52

6-
gulp.task('jekyll-rebuild', ['jekyll-build'], function () {
3+
var gulp = require('gulp'),
4+
browserSync = require('browser-sync');
5+
6+
gulp.task('jekyll-rebuild', ['jekyll-build'], function() {
77
browserSync.reload();
88
});

0 commit comments

Comments
 (0)