Skip to content

Commit e94acaa

Browse files
bderodnfield
authored andcommitted
Match skia's path param ordering (flutter#25)
1 parent 6cd7a45 commit e94acaa

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

impeller/geometry/path_builder.cc

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,8 @@ PathBuilder& PathBuilder::VerticalLineTo(Scalar y, bool relative) {
5858
return *this;
5959
}
6060

61-
PathBuilder& PathBuilder::QuadraticCurveTo(Point point,
62-
Point controlPoint,
61+
PathBuilder& PathBuilder::QuadraticCurveTo(Point controlPoint,
62+
Point point,
6363
bool relative) {
6464
point = relative ? current_ + point : point;
6565
controlPoint = relative ? current_ + controlPoint : controlPoint;
@@ -100,9 +100,9 @@ PathBuilder& PathBuilder::SmoothQuadraticCurveTo(Point point, bool relative) {
100100
return *this;
101101
}
102102

103-
PathBuilder& PathBuilder::CubicCurveTo(Point point,
104-
Point controlPoint1,
103+
PathBuilder& PathBuilder::CubicCurveTo(Point controlPoint1,
105104
Point controlPoint2,
105+
Point point,
106106
bool relative) {
107107
controlPoint1 = relative ? current_ + controlPoint1 : controlPoint1;
108108
controlPoint2 = relative ? current_ + controlPoint2 : controlPoint2;
@@ -135,8 +135,8 @@ Point PathBuilder::ReflectedCubicControlPoint1() const {
135135
return (current_ * 2.0) - cubic.cp2;
136136
}
137137

138-
PathBuilder& PathBuilder::SmoothCubicCurveTo(Point point,
139-
Point controlPoint2,
138+
PathBuilder& PathBuilder::SmoothCubicCurveTo(Point controlPoint2,
139+
Point point,
140140
bool relative) {
141141
auto controlPoint1 = ReflectedCubicControlPoint1();
142142
controlPoint2 = relative ? current_ + controlPoint2 : controlPoint2;

impeller/geometry/path_builder.h

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,19 +33,19 @@ class PathBuilder {
3333

3434
PathBuilder& VerticalLineTo(Scalar y, bool relative = false);
3535

36-
PathBuilder& QuadraticCurveTo(Point point,
37-
Point controlPoint,
36+
PathBuilder& QuadraticCurveTo(Point controlPoint,
37+
Point point,
3838
bool relative = false);
3939

4040
PathBuilder& SmoothQuadraticCurveTo(Point point, bool relative = false);
4141

42-
PathBuilder& CubicCurveTo(Point point,
43-
Point controlPoint1,
42+
PathBuilder& CubicCurveTo(Point controlPoint1,
4443
Point controlPoint2,
44+
Point point,
4545
bool relative = false);
4646

47-
PathBuilder& SmoothCubicCurveTo(Point point,
48-
Point controlPoint2,
47+
PathBuilder& SmoothCubicCurveTo(Point controlPoint2,
48+
Point point,
4949
bool relative = false);
5050

5151
PathBuilder& AddRect(Rect rect);

0 commit comments

Comments
 (0)