Skip to content

Commit f282f41

Browse files
chinmaygardednfield
authored andcommitted
Remove support for the weird 5 byte pixel format.
1 parent 8748c76 commit f282f41

File tree

2 files changed

+0
-12
lines changed

2 files changed

+0
-12
lines changed

impeller/renderer/backend/metal/formats_mtl.h

-4
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,6 @@ constexpr PixelFormat FromMTLPixelFormat(MTLPixelFormat format) {
2525
return PixelFormat::kB8G8R8A8UNormInt;
2626
case MTLPixelFormatBGRA8Unorm_sRGB:
2727
return PixelFormat::kB8G8R8A8UNormIntSRGB;
28-
case MTLPixelFormatDepth32Float_Stencil8:
29-
return PixelFormat::kD32FloatS8UNormInt;
3028
case MTLPixelFormatRGBA8Unorm:
3129
return PixelFormat::kR8G8B8A8UNormInt;
3230
case MTLPixelFormatStencil8:
@@ -47,8 +45,6 @@ constexpr MTLPixelFormat ToMTLPixelFormat(PixelFormat format) {
4745
return MTLPixelFormatBGRA8Unorm;
4846
case PixelFormat::kB8G8R8A8UNormIntSRGB:
4947
return MTLPixelFormatBGRA8Unorm_sRGB;
50-
case PixelFormat::kD32FloatS8UNormInt:
51-
return MTLPixelFormatDepth32Float_Stencil8;
5248
case PixelFormat::kR8G8B8A8UNormInt:
5349
return MTLPixelFormatRGBA8Unorm;
5450
case PixelFormat::kS8UInt:

impeller/renderer/formats.h

-8
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,6 @@ enum class PixelFormat {
5252
kB8G8R8A8UNormIntSRGB,
5353
kS8UInt,
5454

55-
// Esoteric formats only used as render targets.
56-
kD32FloatS8UNormInt,
57-
5855
// Defaults. If you don't know which ones to use, these are usually a safe
5956
// bet.
6057
//
@@ -183,11 +180,6 @@ constexpr size_t BytesPerPixelForPixelFormat(PixelFormat format) {
183180
case PixelFormat::kB8G8R8A8UNormInt:
184181
case PixelFormat::kB8G8R8A8UNormIntSRGB:
185182
return 4u;
186-
case PixelFormat::kD32FloatS8UNormInt:
187-
// This is an esoteric format and implementations may use 64 bits.
188-
// Impeller doesn't work with these natively and this return is only here
189-
// for completeness. The 40 bits is as documented.
190-
return 5u;
191183
}
192184
return 0u;
193185
}

0 commit comments

Comments
 (0)