Remove restart_service on service_limits define

Since 97dd16f this parameter is a bad
idea. It doesn't do a daemon reload and it may restart at the wrong
time. In fact, I'd argue it's always been a bad idea.

The recommended alternative to this is to manage the service explicitly
and let Puppet handle it. There is an automatic notify that takes care
of it.

Fixes voxpupuli#190

Author: ekohl

REFERENCE.md

@@ -1273,7 +1273,6 @@ The following parameters are available in the `systemd::service_limits` defined
 * [`selinux_ignore_defaults`](#-systemd--service_limits--selinux_ignore_defaults)
 * [`limits`](#-systemd--service_limits--limits)
 * [`source`](#-systemd--service_limits--source)
-* [`restart_service`](#-systemd--service_limits--restart_service)
 
 ##### <a name="-systemd--service_limits--name"></a>`name`
 
@@ -1325,14 +1324,6 @@ A ``File`` resource compatible ``source``
 
 Default value: `undef`
 
-##### <a name="-systemd--service_limits--restart_service"></a>`restart_service`
-
-Data type: `Boolean`
-
-Restart the managed service after setting the limits
-
-Default value: `true`
-
 ### <a name="systemd--timer"></a>`systemd::timer`
 
 Create a timer and optionally a service unit to execute with the timer unit

manifests/service_limits.pp

@@ -26,16 +26,12 @@
 #
 #   * Mutually exclusive with ``$limits``
 #
-# @param restart_service
-#   Restart the managed service after setting the limits
-#
 define systemd::service_limits (
   Enum['present', 'absent', 'file'] $ensure                  = 'present',
   Stdlib::Absolutepath              $path                    = '/etc/systemd/system',
   Boolean                           $selinux_ignore_defaults = false,
   Optional[Systemd::ServiceLimits]  $limits                  = undef,
   Optional[String]                  $source                  = undef,
-  Boolean                           $restart_service         = true
 ) {
   include systemd
 
@@ -67,15 +63,6 @@
     selinux_ignore_defaults => $selinux_ignore_defaults,
     content                 => $_content,
     source                  => $source,
-  }
-
-  if $restart_service {
-    exec { "restart ${name} because limits":
-      command     => "systemctl restart ${name}",
-      path        => $facts['path'],
-      refreshonly => true,
-    }
-
-    Systemd::Dropin_file["${name}-90-limits.conf"] ~> Exec["restart ${name} because limits"]
+    notify_service          => true,
   }
 }

spec/defines/service_limits_spec.rb

@@ -51,12 +51,20 @@
               with_content(%r{IOReadBandwidthMax=/bw/max 10K})
           }
 
-          it {
-            expect(subject).to create_exec("restart #{title} because limits").with(
-              command: "systemctl restart #{title}",
-              refreshonly: true
-            )
-          }
+          describe 'with service managed' do
+            let(:pre_condition) do
+              <<-PUPPET
+              service { 'test':
+              }
+              PUPPET
+            end
+
+            it { is_expected.to compile.with_all_deps }
+            it do
+              is_expected.to create_file("/etc/systemd/system/#{title}.d/90-limits.conf").
+                that_notifies('Service[test]')
+            end
+          end
         end
 
         describe 'ensured absent' do
@@ -66,14 +74,7 @@
 
           it do
             expect(subject).to create_file("/etc/systemd/system/#{title}.d/90-limits.conf").
-              with_ensure('absent').
-              that_notifies("Exec[restart #{title} because limits]")
-          end
-
-          it do
-            expect(subject).to create_exec("restart #{title} because limits").
-              with_command("systemctl restart #{title}").
-              with_refreshonly(true)
+              with_ensure('absent')
           end
         end
       end