1111 * the Apache License, Version 2.0 (the "License"); you may
1212 * not use this file except in compliance with the License.
1313 * You may obtain a copy of the License at
14- *
14+ *
1515 * http://www.apache.org/licenses/LICENSE-2.0
16- *
16+ *
1717 * Unless required by applicable law or agreed to in writing,
1818 * software distributed under the License is distributed on an
1919 * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
2626
2727import co .elastic .apm .agent .impl .ElasticApmTracer ;
2828import co .elastic .apm .agent .impl .context .AbstractContext ;
29+ import co .elastic .apm .agent .matcher .WildcardMatcher ;
30+ import co .elastic .apm .agent .objectpool .Recyclable ;
31+ import co .elastic .apm .agent .report .ReporterConfiguration ;
2932import org .slf4j .Logger ;
3033import org .slf4j .LoggerFactory ;
3134
3235import javax .annotation .Nullable ;
3336import java .util .concurrent .Callable ;
3437import java .util .concurrent .TimeUnit ;
3538import java .util .concurrent .atomic .AtomicInteger ;
39+ import java .util .concurrent .atomic .AtomicLong ;
3640
3741public abstract class AbstractSpan <T extends AbstractSpan > extends TraceContextHolder <T > {
3842 private static final Logger logger = LoggerFactory .getLogger (AbstractSpan .class );
@@ -43,37 +47,98 @@ public abstract class AbstractSpan<T extends AbstractSpan> extends TraceContextH
4347 * Generic designation of a transaction in the scope of a single service (eg: 'GET /users/:id')
4448 */
4549 protected final StringBuilder name = new StringBuilder ();
50+ protected final boolean collectBreakdownMetrics ;
4651 private long timestamp ;
4752
48- /**
49- * How long the transaction took to complete, in ms with 3 decimal points
50- * (Required)
51- */
52- protected double duration ;
53+ // in microseconds
54+ protected long duration ;
55+ private ChildDurationTimer childDurations = new ChildDurationTimer ();
5356 protected AtomicInteger references = new AtomicInteger ();
5457 protected volatile boolean finished = true ;
5558
5659 public int getReferenceCount () {
5760 return references .get ();
5861 }
5962
63+ private static class ChildDurationTimer implements Recyclable {
64+
65+ private AtomicInteger activeChildren = new AtomicInteger ();
66+ private AtomicLong start = new AtomicLong ();
67+ private AtomicLong duration = new AtomicLong ();
68+
69+ /**
70+ * Starts the timer if it has not been started already.
71+ *
72+ * @param startTimestamp
73+ */
74+ void onChildStart (long startTimestamp ) {
75+ if (activeChildren .incrementAndGet () == 1 ) {
76+ start .set (startTimestamp );
77+ }
78+ }
79+
80+ /**
81+ * Stops the timer and increments the duration if no other direct children are still running
82+ * @param endTimestamp
83+ */
84+ void onChildEnd (long endTimestamp ) {
85+ if (activeChildren .decrementAndGet () == 0 ) {
86+ incrementDuration (endTimestamp );
87+ }
88+ }
89+
90+ /**
91+ * Stops the timer and increments the duration even if there are direct children which are still running
92+ *
93+ * @param endTimestamp
94+ */
95+ void onSpanEnd (long endTimestamp ) {
96+ if (activeChildren .getAndSet (0 ) != 0 ) {
97+ incrementDuration (endTimestamp );
98+ }
99+ }
100+
101+ private void incrementDuration (long epochMicros ) {
102+ duration .addAndGet (epochMicros - start .get ());
103+ }
104+
105+ @ Override
106+ public void resetState () {
107+ activeChildren .set (0 );
108+ start .set (0 );
109+ duration .set (0 );
110+ }
111+
112+ public long getDuration () {
113+ return duration .get ();
114+ }
115+ }
116+
60117 public AbstractSpan (ElasticApmTracer tracer ) {
61118 super (tracer );
62119 traceContext = TraceContext .with64BitId (this .tracer );
120+ collectBreakdownMetrics = !WildcardMatcher .isAnyMatch (tracer .getConfig (ReporterConfiguration .class ).getDisableMetrics (), "span.self_time" );
63121 }
64122
65123 public boolean isReferenced () {
66124 return references .get () > 0 ;
67125 }
68126
69127 /**
70- * How long the transaction took to complete, in ms with 3 decimal points
71- * (Required)
128+ * How long the transaction took to complete, in µs
72129 */
73- public double getDuration () {
130+ public long getDuration () {
74131 return duration ;
75132 }
76133
134+ public long getSelfDuration () {
135+ return duration - childDurations .getDuration ();
136+ }
137+
138+ public double getDurationMs () {
139+ return duration / AbstractSpan .MS_IN_MICROS ;
140+ }
141+
77142 /**
78143 * Generic designation of a transaction in the scope of a single service (eg: 'GET /users/:id')
79144 */
@@ -124,6 +189,7 @@ public void resetState() {
124189 timestamp = 0 ;
125190 duration = 0 ;
126191 traceContext .resetState ();
192+ childDurations .resetState ();
127193 references .set (0 );
128194 }
129195
@@ -177,20 +243,23 @@ public void end() {
177243
178244 public final void end (long epochMicros ) {
179245 if (!finished ) {
180- this .duration = (epochMicros - timestamp ) / AbstractSpan . MS_IN_MICROS ;
246+ this .duration = (epochMicros - timestamp );
181247 if (name .length () == 0 ) {
182248 name .append ("unnamed" );
183249 }
184- doEnd (epochMicros );
185- // has to be set last so doEnd callbacks don't think it has already been finished
250+ childDurations . onSpanEnd (epochMicros );
251+ beforeEnd ( epochMicros );
186252 this .finished = true ;
253+ afterEnd ();
187254 } else {
188255 logger .warn ("End has already been called: {}" , this );
189256 assert false ;
190257 }
191258 }
192259
193- protected abstract void doEnd (long epochMicros );
260+ protected abstract void beforeEnd (long epochMicros );
261+
262+ protected abstract void afterEnd ();
194263
195264 @ Override
196265 public boolean isChildOf (TraceContextHolder other ) {
@@ -242,6 +311,18 @@ public void setStartTimestamp(long epochMicros) {
242311 timestamp = epochMicros ;
243312 }
244313
314+ void onChildStart (long epochMicros ) {
315+ if (collectBreakdownMetrics ) {
316+ childDurations .onChildStart (epochMicros );
317+ }
318+ }
319+
320+ void onChildEnd (long epochMicros ) {
321+ if (collectBreakdownMetrics ) {
322+ childDurations .onChildEnd (epochMicros );
323+ }
324+ }
325+
245326 public void incrementReferences () {
246327 references .incrementAndGet ();
247328 if (logger .isDebugEnabled ()) {
0 commit comments