Skip to content

Commit ec72778

Browse files
patch fix for 2503 update addressing separate bugs (#2528)
(cherry picked from commit 58ba72d)
1 parent e42eefe commit ec72778

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

detection_rules/rule.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1022,7 +1022,7 @@ def check_restricted_fields_compatibility(self) -> Dict[str, dict]:
10221022
"""Check for compatibility between restricted fields and the min_stack_version of the rule."""
10231023
default_min_stack = get_min_supported_stack_version()
10241024
if self.metadata.min_stack_version is not None:
1025-
min_stack = Version.parse(self.metadata.min_stack_version)
1025+
min_stack = Version.parse(self.metadata.min_stack_version, optional_minor_and_patch=True)
10261026
else:
10271027
min_stack = default_min_stack
10281028
restricted = self.data.get_restricted_fields

tests/test_all_rules.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -617,8 +617,8 @@ def test_event_override(self):
617617
has_event_ingested = rule.contents.data.timestamp_override == 'event.ingested'
618618
indexes = rule.contents.data.get('index', [])
619619
beats_indexes = parse_beats_from_index(indexes)
620-
min_stack_is_less_than_82 = Version.parse(rule.contents.metadata.min_stack_version or '7.13.0') \
621-
< Version.parse("8.2.0")
620+
min_stack_is_less_than_82 = Version.parse(rule.contents.metadata.min_stack_version or '7.13.0',
621+
optional_minor_and_patch=True) < Version.parse("8.2.0")
622622
config = rule.contents.data.get('note') or ''
623623
rule_str = self.rule_str(rule, trailer=None)
624624

0 commit comments

Comments
 (0)