Skip to content

[FR] Adapt PyPi semver Library and Remove Custom #2502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
terrancedejesus opened this issue Jan 27, 2023 · 0 comments · Fixed by #2503
Closed

[FR] Adapt PyPi semver Library and Remove Custom #2502

terrancedejesus opened this issue Jan 27, 2023 · 0 comments · Fixed by #2503
Assignees
Labels
enhancement New feature or request python Internal python for the repository

Comments

@terrancedejesus
Copy link
Contributor

terrancedejesus commented Jan 27, 2023

Is your feature request related to a problem? Please describe.
No.

Describe the solution you'd like
Remove custom semver library from Detection Rules and replace with pypi library. Review all uses of custom library and adjust logic to pypi library.

Describe alternatives you've considered
Creating more custom functions and methods in custom semver library for other Detection Rules functionality.

Additional context
We should adapt the additional functionality of the pypi semver library that is available and reduce management of custom code. Some additional uses necessary such as package-storage semantic versioning filters and adjusting rule versions to semantic versioning will require more functionality that is already available in the pypyi library.

@terrancedejesus terrancedejesus added enhancement New feature or request python Internal python for the repository labels Jan 27, 2023
@terrancedejesus terrancedejesus self-assigned this Jan 27, 2023
@terrancedejesus terrancedejesus linked a pull request Jan 28, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request python Internal python for the repository
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant