Skip to content

[Meta] Integration Validation Refactoring #3680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eric-forte-elastic opened this issue May 15, 2024 · 6 comments
Open

[Meta] Integration Validation Refactoring #3680

eric-forte-elastic opened this issue May 15, 2024 · 6 comments
Labels
backlog enhancement New feature or request Meta python Internal python for the repository

Comments

@eric-forte-elastic
Copy link
Contributor

eric-forte-elastic commented May 15, 2024

Related Issue

#3618

This is a decoupled issue from #3618 to reduce the complexity of the PR review and to more atomically test the changes. Additionally this captures the desire to refactor to make this process smoother while decoupling it from other approaches to solving BYOS.

Summary

We may need to refactor the integrations validation for increased performance and ease of maintenance. This issue is to track the 4 steps needed to address this concern.

### Tasks
- [ ] 1. Investigation: Does the integrations validation take a significant amount of the Rule Loader's computational time
- [ ] 2. LOE determination: Is the return worth the effort, can it be done efficiently
- [ ] 3. Refactor Design
- [ ] 4. Implementation 

Steps/tasks 1-2 should take approximately half a sprint to complete, with the LOE cutoff for proceeding being 1 full sprint of refactoring work.

@eric-forte-elastic eric-forte-elastic added enhancement New feature or request python Internal python for the repository detections-as-code labels May 15, 2024
@eric-forte-elastic eric-forte-elastic self-assigned this May 15, 2024
@Mikaayenson
Copy link
Contributor

Is this really related DAC or should this target main?

@eric-forte-elastic
Copy link
Contributor Author

Is this really related DAC or should this target main?

Good point! This should target main 👍

@eric-forte-elastic eric-forte-elastic changed the title [FR] [DAC] Integration Validation Refactoring [FR] Integration Validation Refactoring May 16, 2024
@brokensound77
Copy link
Contributor

This might be a duplicate of (or should be added as part of #3556

@Mikaayenson
Copy link
Contributor

We should make this measurable and time bound in the design of this (potentially even making this a meta itself).

  • What code refactors specifically for maintenance do we want to do
  • What specific performance refactors will we include.

IMO this is still very ambiguous, so we should design and decide on what do move forward on.

@eric-forte-elastic eric-forte-elastic changed the title [FR] Integration Validation Refactoring [Meta] Integration Validation Refactoring Jun 13, 2024
@eric-forte-elastic
Copy link
Contributor Author

We should make this measurable and time bound in the design of this (potentially even making this a meta itself).

  • What code refactors specifically for maintenance do we want to do
  • What specific performance refactors will we include.

IMO this is still very ambiguous, so we should design and decide on what do move forward on.

Updated to make this a meta and have time bound constraints for implementation.

@eric-forte-elastic
Copy link
Contributor Author

Update 10/9/24

Deprioritized in favor of Falco integration work PM request, moving to Q3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog enhancement New feature or request Meta python Internal python for the repository
Projects
None yet
Development

No branches or pull requests

3 participants