Skip to content

Allowing bool and numbers for labels #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
simitt opened this issue Jan 24, 2019 · 1 comment
Closed

Allowing bool and numbers for labels #310

simitt opened this issue Jan 24, 2019 · 1 comment

Comments

@simitt
Copy link
Contributor

simitt commented Jan 24, 2019

The current description of labels states that the values need to be keywords:

Key/value pairs. Can be used to add meta information to events. Should not contain nested objects. All values are stored as keyword.

Can we extend this to also allow at least boolean and number values? APM uses labels to allow setting user defined information about events. We already allow keywords, numbers and booleans. Numbers could be used for aggregations on these fields. (see elastic/apm-server#828 for more background).

@ebeahan
Copy link
Member

ebeahan commented Apr 15, 2021

I've opened an RFC to start a discussion around this topic: #1341

Let's capture any new thoughts or feedback in that conversation.

@ebeahan ebeahan closed this as completed Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants