Fix order of body read and close

Author: jsoriano

internal/benchrunner/runners/rally/runner.go

@@ -811,10 +811,11 @@ func (r *runner) bulkMetrics(indexName string, sr searchResponse) error {
 	if err != nil {
 		return fmt.Errorf("error executing scroll: %s", err)
 	}
+	defer resp.Body.Close()
+
 	if resp.IsError() {
 		return fmt.Errorf("error executing scroll: %s", resp.String())
 	}
-	resp.Body.Close()
 
 	return nil
 }

internal/dump/ilmpolicies.go

@@ -57,15 +57,15 @@ func getILMPolicyByName(ctx context.Context, api *elasticsearch.API, policy stri
 	}
 	defer resp.Body.Close()
 
+	if resp.IsError() {
+		return nil, fmt.Errorf("failed to get policy %s: %s", policy, resp.String())
+	}
+
 	d, err := io.ReadAll(resp.Body)
 	if err != nil {
 		return nil, fmt.Errorf("failed to read response body: %w", err)
 	}
 
-	if resp.IsError() {
-		return nil, fmt.Errorf("failed to get policy %s: %s", policy, resp.String())
-	}
-
 	var policiesResponse getILMLifecycleResponse
 	err = json.Unmarshal(d, &policiesResponse)
 	if err != nil {

internal/dump/indextemplates.go

@@ -77,15 +77,15 @@ func getIndexTemplatesForPackage(ctx context.Context, api *elasticsearch.API, pa
 	}
 	defer resp.Body.Close()
 
+	if resp.IsError() {
+		return nil, fmt.Errorf("failed to get index templates: %s", resp.String())
+	}
+
 	d, err := io.ReadAll(resp.Body)
 	if err != nil {
 		return nil, fmt.Errorf("failed to read response body: %w", err)
 	}
 
-	if resp.IsError() {
-		return nil, fmt.Errorf("failed to get index templates: %s", resp.String())
-	}
-
 	var templateResponse getIndexTemplateResponse
 	err = json.Unmarshal(d, &templateResponse)
 	if err != nil {

internal/elasticsearch/client.go

@@ -132,15 +132,15 @@ func (client *Client) CheckHealth(ctx context.Context) error {
 	}
 	defer resp.Body.Close()
 
+	if resp.StatusCode != http.StatusOK {
+		return fmt.Errorf("failed to check cluster health: %s", resp.String())
+	}
+
 	body, err := io.ReadAll(resp.Body)
 	if err != nil {
 		return fmt.Errorf("error reading cluster health response: %w", err)
 	}
 
-	if resp.StatusCode != http.StatusOK {
-		return fmt.Errorf("failed to check cluster health; API status code = %d; response body = %s", resp.StatusCode, string(body))
-	}
-
 	var clusterHealth struct {
 		Status string `json:"status"`
 	}