Skip to content

Support traces data stream type #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ycombinator opened this issue Jan 15, 2021 · 2 comments · Fixed by #258
Closed

Support traces data stream type #223

ycombinator opened this issue Jan 15, 2021 · 2 comments · Fixed by #258
Assignees
@ycombinator
Labels
enhancement New feature or request

Comments

@ycombinator
Copy link
Contributor

In elastic/package-spec#78, a new data stream type, traces, was added for supporting APM packages. This may have implications on elastic-package. We should figure out what those might be and support this new type.

cc: @elastic/apm-server.
@ycombinator ycombinator added the enhancement New feature or request label Jan 15, 2021
@ycombinator ycombinator mentioned this issue Jan 15, 2021
Merged
7 tasks
@mtojek
Copy link
Contributor

mtojek commented Feb 16, 2021

I guess we can close this issue, @ycombinator ?

@ycombinator
Copy link
Contributor Author

I'm not sure. Do we do anything special for logs vs. metrics in elastic-package? IIRC there's a conditional in the code for pipeline tests so they only run on logs data streams? I was hoping to look for such special cases and see if we need to account for traces. I'm 90% sure we are good as-is, but just wanted to look through the code and make sure of it.

@ycombinator ycombinator self-assigned this Feb 18, 2021
@ycombinator ycombinator mentioned this issue Feb 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ycombinator ycombinator

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support data stream type == traces ycombinator/elastic-package
2 participants
@ycombinator @mtojek