Skip to content

Commit 7749055

Browse files
committed
Fix non working update dynamic settings
Described in elastic/elasticsearch#10614, it's not possible with cloud discovery plugin to update dynamic settings anymore. ```sh curl -XPUT localhost:9200/_cluster/settings -d '{ "persistent" : { "discovery.zen.minimum_master_nodes" : 3 }, "transient" : { "discovery.zen.minimum_master_nodes" : 3 } }' ``` gives ```json {"acknowledged":true,"persistent":{},"transient":{}} ``` Closes #80.
1 parent 0e2f436 commit 7749055

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/main/java/org/elasticsearch/discovery/azure/AzureDiscovery.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
import org.elasticsearch.cluster.ClusterName;
2525
import org.elasticsearch.cluster.ClusterService;
2626
import org.elasticsearch.cluster.node.DiscoveryNodeService;
27+
import org.elasticsearch.cluster.settings.ClusterDynamicSettings;
2728
import org.elasticsearch.cluster.settings.DynamicSettings;
2829
import org.elasticsearch.common.collect.ImmutableList;
2930
import org.elasticsearch.common.inject.Inject;
@@ -50,7 +51,7 @@ public class AzureDiscovery extends ZenDiscovery {
5051
public AzureDiscovery(Settings settings, ClusterName clusterName, ThreadPool threadPool, TransportService transportService,
5152
ClusterService clusterService, NodeSettingsService nodeSettingsService, ZenPingService pingService,
5253
DiscoveryNodeService discoveryNodeService, AzureComputeService azureService, NetworkService networkService,
53-
DiscoverySettings discoverySettings, ElectMasterService electMasterService, DynamicSettings dynamicSettings,
54+
DiscoverySettings discoverySettings, ElectMasterService electMasterService, @ClusterDynamicSettings DynamicSettings dynamicSettings,
5455
Version version) {
5556
super(settings, clusterName, threadPool, transportService, clusterService, nodeSettingsService,
5657
discoveryNodeService, pingService, electMasterService, discoverySettings, dynamicSettings);

0 commit comments

Comments
 (0)