Skip to content
This repository was archived by the owner on Jan 31, 2024. It is now read-only.

Commit ebe75a3

Browse files
committed
Fix non working update dynamic settings
Described in elastic/elasticsearch#10614, it's not possible with cloud discovery plugin to update dynamic settings anymore. ```sh curl -XPUT localhost:9200/_cluster/settings -d '{ "persistent" : { "discovery.zen.minimum_master_nodes" : 3 }, "transient" : { "discovery.zen.minimum_master_nodes" : 3 } }' ``` gives ```json {"acknowledged":true,"persistent":{},"transient":{}} ``` Closes #47. (cherry picked from commit 9df33a3) (cherry picked from commit a40016e)
1 parent 75a8d12 commit ebe75a3

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/main/java/org/elasticsearch/discovery/gce/GceDiscovery.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
import org.elasticsearch.cluster.ClusterName;
2525
import org.elasticsearch.cluster.ClusterService;
2626
import org.elasticsearch.cluster.node.DiscoveryNodeService;
27+
import org.elasticsearch.cluster.settings.ClusterDynamicSettings;
2728
import org.elasticsearch.cluster.settings.DynamicSettings;
2829
import org.elasticsearch.common.collect.ImmutableList;
2930
import org.elasticsearch.common.inject.Inject;
@@ -49,7 +50,7 @@ public GceDiscovery(Settings settings, ClusterName clusterName, ThreadPool threa
4950
ClusterService clusterService, NodeSettingsService nodeSettingsService, ZenPingService pingService,
5051
DiscoveryNodeService discoveryNodeService, GceComputeService gceComputeService,
5152
NetworkService networkService, DiscoverySettings discoverySettings,
52-
ElectMasterService electMasterService, DynamicSettings dynamicSettings,
53+
ElectMasterService electMasterService, @ClusterDynamicSettings DynamicSettings dynamicSettings,
5354
Version version) {
5455
super(settings, clusterName, threadPool, transportService, clusterService, nodeSettingsService,
5556
discoveryNodeService, pingService, electMasterService, discoverySettings, dynamicSettings);

0 commit comments

Comments
 (0)