Skip to content

Commit d0f1aad

Browse files
authored
public object adapter class, comment (#764)
1 parent d1dfacd commit d0f1aad

File tree

4 files changed

+9
-4
lines changed

4 files changed

+9
-4
lines changed

java-client/src/main-flavored/java/co/elastic/clients/elasticsearch/_helpers/esql/EsqlAdapter.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public interface EsqlAdapter<Result> {
3636
String format();
3737

3838
/**
39-
* For JSON results, whether the result should be organized in rows or columns
39+
* For JSON like results, whether the result should be organized in rows or columns
4040
*/
4141
boolean columnar();
4242

java-client/src/main-flavored/java/co/elastic/clients/elasticsearch/_helpers/esql/ObjectsEsqlAdapter.java renamed to java-client/src/main-flavored/java/co/elastic/clients/elasticsearch/_helpers/esql/objects/ObjectsEsqlAdapter.java

+6-3
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,12 @@
1717
* under the License.
1818
*/
1919

20-
package co.elastic.clients.elasticsearch._helpers.esql;
20+
package co.elastic.clients.elasticsearch._helpers.esql.objects;
2121

2222
import co.elastic.clients.ApiClient;
23+
import co.elastic.clients.elasticsearch._helpers.esql.EsqlAdapter;
24+
import co.elastic.clients.elasticsearch._helpers.esql.EsqlAdapterBase;
25+
import co.elastic.clients.elasticsearch._helpers.esql.EsqlMetadata;
2326
import co.elastic.clients.elasticsearch.esql.QueryRequest;
2427
import co.elastic.clients.json.BufferingJsonGenerator;
2528
import co.elastic.clients.json.BufferingJsonpMapper;
@@ -37,7 +40,7 @@
3740
/**
3841
* And ES|QL adapter that returns an iterable of domain objects
3942
*/
40-
class ObjectsEsqlAdapter<T> implements EsqlAdapter<Iterable<T>> {
43+
public class ObjectsEsqlAdapter<T> implements EsqlAdapter<Iterable<T>> {
4144

4245
public static <T> ObjectsEsqlAdapter<T> of(Class<T> clazz) {
4346
return new ObjectsEsqlAdapter<>(clazz);
@@ -49,7 +52,7 @@ public static <T> ObjectsEsqlAdapter<T> of(Type type) {
4952

5053
private final Type type;
5154

52-
ObjectsEsqlAdapter(Type type) {
55+
public ObjectsEsqlAdapter(Type type) {
5356
this.type = type;
5457
}
5558

java-client/src/test/java/co/elastic/clients/elasticsearch/_helpers/esql/EsqlAdapterEndToEndTest.java

+1
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
import co.elastic.clients.elasticsearch.ElasticsearchClient;
2424
import co.elastic.clients.elasticsearch.ElasticsearchTestServer;
2525
import co.elastic.clients.elasticsearch._helpers.esql.jdbc.ResultSetEsqlAdapter;
26+
import co.elastic.clients.elasticsearch._helpers.esql.objects.ObjectsEsqlAdapter;
2627
import co.elastic.clients.json.jackson.JacksonJsonpMapper;
2728
import co.elastic.clients.transport.rest_client.RestClientTransport;
2829
import com.fasterxml.jackson.annotation.JsonIgnoreProperties;

java-client/src/test/java/co/elastic/clients/elasticsearch/_helpers/esql/EsqlAdapterTest.java

+1
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121

2222
import co.elastic.clients.elasticsearch.ElasticsearchClient;
2323
import co.elastic.clients.elasticsearch._helpers.esql.jdbc.ResultSetEsqlAdapter;
24+
import co.elastic.clients.elasticsearch._helpers.esql.objects.ObjectsEsqlAdapter;
2425
import co.elastic.clients.json.jackson.JacksonJsonpMapper;
2526
import co.elastic.clients.testkit.MockHttpClient;
2627
import co.elastic.clients.transport.endpoints.BinaryResponse;

0 commit comments

Comments
 (0)