Merge pull request #1211 from elasticsearch/fix/compress-body

gmarz · gmarz · commit 010ca844c6ee · 2015-01-22T17:22:15.000-05:00
Fix/compress body
diff --git a/src/Connections/Elasticsearch.Net.Connection.HttpClient/HttpClientConnection.cs b/src/Connections/Elasticsearch.Net.Connection.HttpClient/HttpClientConnection.cs
@@ -58,7 +58,7 @@ public HttpClientConnection(IConnectionConfigurationValues settings, HttpClientH
 			{
 				Timeout = TimeSpan.FromMilliseconds(_settings.Timeout)
 			};
-			if (settings.EnableCompressedResponses && innerHandler.SupportsAutomaticDecompression)
+			if (settings.EnableCompressedResponses || settings.EnableHttpCompression && innerHandler.SupportsAutomaticDecompression)
 			{
 				innerHandler.AutomaticDecompression = DecompressionMethods.GZip | DecompressionMethods.Deflate;
 				Client.DefaultRequestHeaders.AcceptEncoding.Add(new StringWithQualityHeaderValue("gzip"));
@@ -97,12 +97,10 @@ public ElasticsearchResponse<Stream> DoRequestSync(HttpMethod method, Uri uri, b
 		{
 			ThrowIfDisposed();
 
-			var requestTask = DoRequest(method, uri, data, requestSpecificConfig);
-
 			try
 			{
-				requestTask.Wait();
-				return requestTask.Result;
+				return this.DoRequestInternal(method, uri, data, requestSpecificConfig)
+					.Result;
 			}
 			catch (AggregateException ex)
 			{
@@ -123,6 +121,12 @@ public ElasticsearchResponse<Stream> DoRequestSync(HttpMethod method, Uri uri, b
 		/// <param name="requestSpecificConfig">The request specific configuration.</param>
 		/// <returns>Task&lt;ElasticsearchResponse&lt;Stream&gt;&gt;.</returns>
 		public async Task<ElasticsearchResponse<Stream>> DoRequest(HttpMethod method, Uri uri, byte[] data = null, IRequestConfiguration requestSpecificConfig = null)
+		{
+			return await this.DoRequestInternal(method, uri, data, requestSpecificConfig).ConfigureAwait(false);
+		}
+
+		public async Task<ElasticsearchResponse<Stream>> DoRequestInternal(
+			HttpMethod method, Uri uri, byte[] data = null, IRequestConfiguration requestSpecificConfig = null)
 		{
 			ThrowIfDisposed();
 
@@ -146,7 +150,8 @@ public async Task<ElasticsearchResponse<Stream>> DoRequest(HttpMethod method, Ur
 						request.Content.Headers.ContentType = new MediaTypeHeaderValue(DefaultContentType);
 				}
 
-				var response = await Client.SendAsync(request, HttpCompletionOption.ResponseHeadersRead);
+				var response = await Client.SendAsync(request, HttpCompletionOption.ResponseHeadersRead)
+					.ConfigureAwait(false);
 
 				if (method == HttpMethod.Head || response.Content == null)
 				{
diff --git a/src/Elasticsearch.Net/Connection/Configuration/ConnectionConfiguration.cs b/src/Elasticsearch.Net/Connection/Configuration/ConnectionConfiguration.cs
@@ -113,8 +113,11 @@ public class ConnectionConfiguration<T> : IConnectionConfigurationValues, IHideO
 		private TimeSpan? _sniffLifeSpan;
 		TimeSpan? IConnectionConfigurationValues.SniffInformationLifeSpan { get{ return _sniffLifeSpan; } }
 
-		private bool _compressionEnabled;
-		bool IConnectionConfigurationValues.EnableCompressedResponses { get{ return _compressionEnabled; } }
+		private bool _enableCompressedResponses;
+		bool IConnectionConfigurationValues.EnableCompressedResponses { get{ return _enableCompressedResponses; } }
+
+		private bool _enableHttpCompression;
+		bool IConnectionConfigurationValues.EnableHttpCompression { get{ return _enableHttpCompression; } }
 
 		private bool _traceEnabled;
 		bool IConnectionConfigurationValues.TraceEnabled { get{ return _traceEnabled; } }
@@ -179,9 +182,20 @@ public T SniffLifeSpan(TimeSpan sniffTimeSpan)
 		/// Enable compressed responses from elasticsearch (NOTE that that nodes need to be configured to allow this)
 		/// http://www.elasticsearch.org/guide/en/elasticsearch/reference/current/modules-http.html
 		/// </summary>
+		[Obsolete("Scheduled to be removed in 2.0, please use EnableHttpCompression")]
 		public T EnableCompressedResponses(bool enabled = true)
 		{
-			this._compressionEnabled = enabled;
+			this._enableCompressedResponses = enabled;
+			return (T) this;
+		}
+
+		/// <summary>
+		/// Enable gzip compressed requests and responses, do note that you need to configure elasticsearch to set this
+		/// <see cref="http://www.elasticsearch.org/guide/en/elasticsearch/reference/current/modules-http.html"/>
+		/// </summary>
+		public T EnableHttpCompression(bool enabled = true)
+		{
+			this._enableHttpCompression = enabled;
 			return (T) this;
 		}
 
diff --git a/src/Elasticsearch.Net/Connection/Configuration/IConnectionConfigurationValues.cs b/src/Elasticsearch.Net/Connection/Configuration/IConnectionConfigurationValues.cs
@@ -70,7 +70,14 @@ public interface IConnectionConfigurationValues
 		/// <summary>
 		/// When set signals elasticsearch to respond with compressed responses
 		/// </summary>
+		[Obsolete("Scheduled to be removed in 2.0, please use EnableHttpCompression")]
 		bool EnableCompressedResponses { get; }
+
+		/// <summary>
+		/// Enable gzip compressed requests and responses, do note that you need to configure elasticsearch to set this
+		/// <see cref="http://www.elasticsearch.org/guide/en/elasticsearch/reference/current/modules-http.html"/>
+		/// </summary>
+		bool EnableHttpCompression { get; }
 		
 		/// <summary>
 		/// When set will force all connections through this proxy
diff --git a/src/Elasticsearch.Net/Connection/HttpConnection.cs b/src/Elasticsearch.Net/Connection/HttpConnection.cs
@@ -67,20 +67,22 @@ public virtual ElasticsearchResponse<Stream> PostSync(Uri uri, byte[] data, IReq
 		{
 			return this.BodyRequest(uri, data, "POST", requestSpecificConfig);
 		}
+		
 		public virtual ElasticsearchResponse<Stream> PutSync(Uri uri, byte[] data, IRequestConfiguration requestSpecificConfig = null)
 		{
 			return this.BodyRequest(uri, data, "PUT", requestSpecificConfig);
 		}
+		
 		public virtual ElasticsearchResponse<Stream> DeleteSync(Uri uri, IRequestConfiguration requestSpecificConfig = null)
 		{
 			return this.HeaderOnlyRequest(uri, "DELETE", requestSpecificConfig);
 		}
+		
 		public virtual ElasticsearchResponse<Stream> DeleteSync(Uri uri, byte[] data, IRequestConfiguration requestSpecificConfig = null)
 		{
 			return this.BodyRequest(uri, data, "DELETE", requestSpecificConfig);
 		}
 
-
 		private ElasticsearchResponse<Stream> HeaderOnlyRequest(Uri uri, string method, IRequestConfiguration requestSpecificConfig)
 		{
 			var r = this.CreateHttpWebRequest(uri, method, null, requestSpecificConfig);
@@ -93,17 +95,18 @@ private ElasticsearchResponse<Stream> BodyRequest(Uri uri, byte[] data, string m
 			return this.DoSynchronousRequest(r, data, requestSpecificConfig);
 		}
 
-
 		public virtual Task<ElasticsearchResponse<Stream>> Get(Uri uri, IRequestConfiguration requestSpecificConfig = null)
 		{
 			var r = this.CreateHttpWebRequest(uri, "GET", null, requestSpecificConfig);
 			return this.DoAsyncRequest(r, requestSpecificConfig: requestSpecificConfig);
 		}
+		
 		public virtual Task<ElasticsearchResponse<Stream>> Head(Uri uri, IRequestConfiguration requestSpecificConfig = null)
 		{
 			var r = this.CreateHttpWebRequest(uri, "HEAD", null, requestSpecificConfig);
 			return this.DoAsyncRequest(r, requestSpecificConfig: requestSpecificConfig);
 		}
+		
 		public virtual Task<ElasticsearchResponse<Stream>> Post(Uri uri, byte[] data, IRequestConfiguration requestSpecificConfig = null)
 		{
 			var r = this.CreateHttpWebRequest(uri, "POST", data, requestSpecificConfig);
@@ -121,6 +124,7 @@ public virtual Task<ElasticsearchResponse<Stream>> Delete(Uri uri, byte[] data,
 			var r = this.CreateHttpWebRequest(uri, "DELETE", data, requestSpecificConfig);
 			return this.DoAsyncRequest(r, data, requestSpecificConfig: requestSpecificConfig);
 		}
+		
 		public virtual Task<ElasticsearchResponse<Stream>> Delete(Uri uri, IRequestConfiguration requestSpecificConfig = null)
 		{
 			var r = this.CreateHttpWebRequest(uri, "DELETE", null, requestSpecificConfig);
@@ -201,10 +205,13 @@ protected virtual HttpWebRequest CreateWebRequest(Uri uri, string method, byte[]
 			request.Pipelined = this.ConnectionSettings.HttpPipeliningEnabled
 				|| (requestSpecificConfig != null && requestSpecificConfig.EnableHttpPipelining);
 
-			if (this.ConnectionSettings.EnableCompressedResponses)
+			if (this.ConnectionSettings.EnableCompressedResponses
+				|| this.ConnectionSettings.EnableHttpCompression)
 			{
 				request.AutomaticDecompression = DecompressionMethods.GZip | DecompressionMethods.Deflate;
 				request.Headers.Add("Accept-Encoding", "gzip,deflate");
+				if (this.ConnectionSettings.EnableHttpCompression)
+					request.Headers.Add("Content-Encoding", "gzip");
 			}
 
 			if (requestSpecificConfig != null && !string.IsNullOrWhiteSpace(requestSpecificConfig.ContentType))
@@ -235,9 +242,14 @@ protected virtual ElasticsearchResponse<Stream> DoSynchronousRequest(HttpWebRequ
 
 			if (data != null)
 			{
+
 				using (var r = request.GetRequestStream())
 				{
-					r.Write(data, 0, data.Length);
+					if (this.ConnectionSettings.EnableHttpCompression)
+						using (var zipStream = new GZipStream(r, CompressionMode.Compress))
+							zipStream.Write(data, 0, data.Length);
+					else 
+						r.Write(data, 0, data.Length);
 				}
 			}
 			try
@@ -325,8 +337,22 @@ private IEnumerable<Task> _AsyncSteps(HttpWebRequest request, TaskCompletionSour
 				var requestStream = getRequestStream.Result;
 				try
 				{
-					var writeToRequestStream = Task.Factory.FromAsync(requestStream.BeginWrite, requestStream.EndWrite, data, 0, data.Length, null);
-					yield return writeToRequestStream;
+					if (this.ConnectionSettings.EnableHttpCompression)
+					{
+						using (var zipStream = new GZipStream(requestStream, CompressionMode.Compress))
+						{
+
+							var writeToRequestStream = Task.Factory.FromAsync(zipStream.BeginWrite, zipStream.EndWrite, data, 0,
+								data.Length, null);
+							yield return writeToRequestStream;
+						}
+					}
+					else
+					{
+						var writeToRequestStream = Task.Factory.FromAsync(requestStream.BeginWrite, requestStream.EndWrite, data, 0,
+							data.Length, null);
+						yield return writeToRequestStream;
+					}
 				}
 				finally
 				{
diff --git a/src/Tests/Elasticsearch.Net.Integration.Yaml/YamlTestsBase.cs b/src/Tests/Elasticsearch.Net.Integration.Yaml/YamlTestsBase.cs
@@ -31,8 +31,6 @@ static YamlTestsBase()
 			var uri = new Uri("http://"+host+":9200/");
 			var settings = new ConnectionConfiguration(uri).ExposeRawResponse();
 
-			var jsonNetSerializer = new ElasticsearchJsonNetSerializer();
-
 			_client = new ElasticsearchClient(settings);
 			//_client = new ElasticsearchClient(settings, serializer: jsonNetSerializer);
 			var infoResponse = _client.Info();
diff --git a/src/Tests/Nest.Tests.Integration/Core/AsyncTests.cs b/src/Tests/Nest.Tests.Integration/Core/AsyncTests.cs
@@ -8,17 +8,14 @@ public class AsyncTests : IntegrationTests
 	{
 
 		[Test]
-		public void TestIndex()
+		public async void TestIndex()
 		{
 			var newProject = new ElasticsearchProject
 			{
 				Name = "COBOLES", //COBOL ES client ?
 			};
-			var t = this.Client.IndexAsync<ElasticsearchProject>(newProject);
-			t.Wait();
-			Assert.True(t.Result.IsValid);
-			Assert.True(t.IsCompleted, "task did not complete");
-			Assert.True(t.IsCompleted, "task did not complete");
+			var t = await  this.Client.IndexAsync<ElasticsearchProject>(newProject);
+			Assert.True(t.IsValid);
 		}
 		
 	}

Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ public HttpClientConnection(IConnectionConfigurationValues settings, HttpClientH`
`58`	`58`	`{`
`59`	`59`	`Timeout = TimeSpan.FromMilliseconds(_settings.Timeout)`
`60`	`60`	`};`
`61`		`- if (settings.EnableCompressedResponses && innerHandler.SupportsAutomaticDecompression)`
	`61`	`+ if (settings.EnableCompressedResponses \|\| settings.EnableHttpCompression && innerHandler.SupportsAutomaticDecompression)`
`62`	`62`	`{`
`63`	`63`	`innerHandler.AutomaticDecompression = DecompressionMethods.GZip \| DecompressionMethods.Deflate;`
`64`	`64`	`Client.DefaultRequestHeaders.AcceptEncoding.Add(new StringWithQualityHeaderValue("gzip"));`
`@@ -97,12 +97,10 @@ public ElasticsearchResponse<Stream> DoRequestSync(HttpMethod method, Uri uri, b`
`97`	`97`	`{`
`98`	`98`	`ThrowIfDisposed();`
`99`	`99`
`100`		`- var requestTask = DoRequest(method, uri, data, requestSpecificConfig);`
`101`		`-`
`102`	`100`	`try`
`103`	`101`	`{`
`104`		`- requestTask.Wait();`
`105`		`- return requestTask.Result;`
	`102`	`+ return this.DoRequestInternal(method, uri, data, requestSpecificConfig)`
	`103`	`+ .Result;`
`106`	`104`	`}`
`107`	`105`	`catch (AggregateException ex)`
`108`	`106`	`{`
`@@ -123,6 +121,12 @@ public ElasticsearchResponse<Stream> DoRequestSync(HttpMethod method, Uri uri, b`
`123`	`121`	`/// <param name="requestSpecificConfig">The request specific configuration.</param>`
`124`	`122`	`/// <returns>Task<ElasticsearchResponse<Stream>>.</returns>`
`125`	`123`	`public async Task<ElasticsearchResponse<Stream>> DoRequest(HttpMethod method, Uri uri, byte[] data = null, IRequestConfiguration requestSpecificConfig = null)`
	`124`	`+ {`
	`125`	`+ return await this.DoRequestInternal(method, uri, data, requestSpecificConfig).ConfigureAwait(false);`
	`126`	`+ }`
	`127`	`+`
	`128`	`+ public async Task<ElasticsearchResponse<Stream>> DoRequestInternal(`
	`129`	`+ HttpMethod method, Uri uri, byte[] data = null, IRequestConfiguration requestSpecificConfig = null)`
`126`	`130`	`{`
`127`	`131`	`ThrowIfDisposed();`
`128`	`132`
`@@ -146,7 +150,8 @@ public async Task<ElasticsearchResponse<Stream>> DoRequest(HttpMethod method, Ur`
`146`	`150`	`request.Content.Headers.ContentType = new MediaTypeHeaderValue(DefaultContentType);`
`147`	`151`	`}`
`148`	`152`
`149`		`- var response = await Client.SendAsync(request, HttpCompletionOption.ResponseHeadersRead);`
	`153`	`+ var response = await Client.SendAsync(request, HttpCompletionOption.ResponseHeadersRead)`
	`154`	`+ .ConfigureAwait(false);`
`150`	`155`
`151`	`156`	`if (method == HttpMethod.Head \|\| response.Content == null)`
`152`	`157`	`{`
Original file line number	Diff line number	Diff line change
`@@ -67,20 +67,22 @@ public virtual ElasticsearchResponse<Stream> PostSync(Uri uri, byte[] data, IReq`
`67`	`67`	`{`
`68`	`68`	`return this.BodyRequest(uri, data, "POST", requestSpecificConfig);`
`69`	`69`	`}`
	`70`	`+`
`70`	`71`	`public virtual ElasticsearchResponse<Stream> PutSync(Uri uri, byte[] data, IRequestConfiguration requestSpecificConfig = null)`
`71`	`72`	`{`
`72`	`73`	`return this.BodyRequest(uri, data, "PUT", requestSpecificConfig);`
`73`	`74`	`}`
	`75`	`+`
`74`	`76`	`public virtual ElasticsearchResponse<Stream> DeleteSync(Uri uri, IRequestConfiguration requestSpecificConfig = null)`
`75`	`77`	`{`
`76`	`78`	`return this.HeaderOnlyRequest(uri, "DELETE", requestSpecificConfig);`
`77`	`79`	`}`
	`80`	`+`
`78`	`81`	`public virtual ElasticsearchResponse<Stream> DeleteSync(Uri uri, byte[] data, IRequestConfiguration requestSpecificConfig = null)`
`79`	`82`	`{`
`80`	`83`	`return this.BodyRequest(uri, data, "DELETE", requestSpecificConfig);`
`81`	`84`	`}`
`82`	`85`
`83`		`-`
`84`	`86`	`private ElasticsearchResponse<Stream> HeaderOnlyRequest(Uri uri, string method, IRequestConfiguration requestSpecificConfig)`
`85`	`87`	`{`
`86`	`88`	`var r = this.CreateHttpWebRequest(uri, method, null, requestSpecificConfig);`
`@@ -93,17 +95,18 @@ private ElasticsearchResponse<Stream> BodyRequest(Uri uri, byte[] data, string m`
`93`	`95`	`return this.DoSynchronousRequest(r, data, requestSpecificConfig);`
`94`	`96`	`}`
`95`	`97`
`96`		`-`
`97`	`98`	`public virtual Task<ElasticsearchResponse<Stream>> Get(Uri uri, IRequestConfiguration requestSpecificConfig = null)`
`98`	`99`	`{`
`99`	`100`	`var r = this.CreateHttpWebRequest(uri, "GET", null, requestSpecificConfig);`
`100`	`101`	`return this.DoAsyncRequest(r, requestSpecificConfig: requestSpecificConfig);`
`101`	`102`	`}`
	`103`	`+`
`102`	`104`	`public virtual Task<ElasticsearchResponse<Stream>> Head(Uri uri, IRequestConfiguration requestSpecificConfig = null)`
`103`	`105`	`{`
`104`	`106`	`var r = this.CreateHttpWebRequest(uri, "HEAD", null, requestSpecificConfig);`
`105`	`107`	`return this.DoAsyncRequest(r, requestSpecificConfig: requestSpecificConfig);`
`106`	`108`	`}`
	`109`	`+`
`107`	`110`	`public virtual Task<ElasticsearchResponse<Stream>> Post(Uri uri, byte[] data, IRequestConfiguration requestSpecificConfig = null)`
`108`	`111`	`{`
`109`	`112`	`var r = this.CreateHttpWebRequest(uri, "POST", data, requestSpecificConfig);`
`@@ -121,6 +124,7 @@ public virtual Task<ElasticsearchResponse<Stream>> Delete(Uri uri, byte[] data,`
`121`	`124`	`var r = this.CreateHttpWebRequest(uri, "DELETE", data, requestSpecificConfig);`
`122`	`125`	`return this.DoAsyncRequest(r, data, requestSpecificConfig: requestSpecificConfig);`
`123`	`126`	`}`
	`127`	`+`
`124`	`128`	`public virtual Task<ElasticsearchResponse<Stream>> Delete(Uri uri, IRequestConfiguration requestSpecificConfig = null)`
`125`	`129`	`{`
`126`	`130`	`var r = this.CreateHttpWebRequest(uri, "DELETE", null, requestSpecificConfig);`
`@@ -201,10 +205,13 @@ protected virtual HttpWebRequest CreateWebRequest(Uri uri, string method, byte[]`
`201`	`205`	`request.Pipelined = this.ConnectionSettings.HttpPipeliningEnabled`
`202`	`206`	`\|\| (requestSpecificConfig != null && requestSpecificConfig.EnableHttpPipelining);`
`203`	`207`
`204`		`- if (this.ConnectionSettings.EnableCompressedResponses)`
	`208`	`+ if (this.ConnectionSettings.EnableCompressedResponses`
	`209`	`+ \|\| this.ConnectionSettings.EnableHttpCompression)`
`205`	`210`	`{`
`206`	`211`	`request.AutomaticDecompression = DecompressionMethods.GZip \| DecompressionMethods.Deflate;`
`207`	`212`	`request.Headers.Add("Accept-Encoding", "gzip,deflate");`
	`213`	`+ if (this.ConnectionSettings.EnableHttpCompression)`
	`214`	`+ request.Headers.Add("Content-Encoding", "gzip");`
`208`	`215`	`}`
`209`	`216`
`210`	`217`	`if (requestSpecificConfig != null && !string.IsNullOrWhiteSpace(requestSpecificConfig.ContentType))`
`@@ -235,9 +242,14 @@ protected virtual ElasticsearchResponse<Stream> DoSynchronousRequest(HttpWebRequ`
`235`	`242`
`236`	`243`	`if (data != null)`
`237`	`244`	`{`
	`245`	`+`
`238`	`246`	`using (var r = request.GetRequestStream())`
`239`	`247`	`{`
`240`		`- r.Write(data, 0, data.Length);`
	`248`	`+ if (this.ConnectionSettings.EnableHttpCompression)`
	`249`	`+ using (var zipStream = new GZipStream(r, CompressionMode.Compress))`
	`250`	`+ zipStream.Write(data, 0, data.Length);`
	`251`	`+ else`
	`252`	`+ r.Write(data, 0, data.Length);`
`241`	`253`	`}`
`242`	`254`	`}`
`243`	`255`	`try`
`@@ -325,8 +337,22 @@ private IEnumerable<Task> _AsyncSteps(HttpWebRequest request, TaskCompletionSour`
`325`	`337`	`var requestStream = getRequestStream.Result;`
`326`	`338`	`try`
`327`	`339`	`{`
`328`		`- var writeToRequestStream = Task.Factory.FromAsync(requestStream.BeginWrite, requestStream.EndWrite, data, 0, data.Length, null);`
`329`		`- yield return writeToRequestStream;`
	`340`	`+ if (this.ConnectionSettings.EnableHttpCompression)`
	`341`	`+ {`
	`342`	`+ using (var zipStream = new GZipStream(requestStream, CompressionMode.Compress))`
	`343`	`+ {`
	`344`	`+`
	`345`	`+ var writeToRequestStream = Task.Factory.FromAsync(zipStream.BeginWrite, zipStream.EndWrite, data, 0,`
	`346`	`+ data.Length, null);`
	`347`	`+ yield return writeToRequestStream;`
	`348`	`+ }`
	`349`	`+ }`
	`350`	`+ else`
	`351`	`+ {`
	`352`	`+ var writeToRequestStream = Task.Factory.FromAsync(requestStream.BeginWrite, requestStream.EndWrite, data, 0,`
	`353`	`+ data.Length, null);`
	`354`	`+ yield return writeToRequestStream;`
	`355`	`+ }`
`330`	`356`	`}`
`331`	`357`	`finally`
`332`	`358`	`{`
Original file line number	Diff line number	Diff line change
`@@ -8,17 +8,14 @@ public class AsyncTests : IntegrationTests`
`8`	`8`	`{`
`9`	`9`
`10`	`10`	`[Test]`
`11`		`- public void TestIndex()`
	`11`	`+ public async void TestIndex()`
`12`	`12`	`{`
`13`	`13`	`var newProject = new ElasticsearchProject`
`14`	`14`	`{`
`15`	`15`	`Name = "COBOLES", //COBOL ES client ?`
`16`	`16`	`};`
`17`		`- var t = this.Client.IndexAsync<ElasticsearchProject>(newProject);`
`18`		`- t.Wait();`
`19`		`- Assert.True(t.Result.IsValid);`
`20`		`- Assert.True(t.IsCompleted, "task did not complete");`
`21`		`- Assert.True(t.IsCompleted, "task did not complete");`
	`17`	`+ var t = await this.Client.IndexAsync<ElasticsearchProject>(newProject);`
	`18`	`+ Assert.True(t.IsValid);`
`22`	`19`	`}`
`23`	`20`
`24`	`21`	`}`