Fix #1154: snapshot failures are objects, not strings

Author: gmarz

src/Nest/Domain/Repository/Snapshot.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Linq;
 using System.Collections.Generic;
 using Newtonsoft.Json;
 
@@ -8,24 +9,47 @@ public class Snapshot
 	{
 		[JsonProperty("snapshot")]
 		public string Name { get; internal set;  }
+
 		[JsonProperty("indices")]
 		public IEnumerable<string> Indices { get; internal set; }
 
 		[JsonProperty("state")]
 		public string State { get; internal set; }
+
 		[JsonProperty("start_time")]
 		public DateTime StartTime { get; internal set;  }
+		
 		[JsonProperty("start_time_in_millis")]
 		public long StartTimeInMilliseconds { get; internal set;  }
+		
 		[JsonProperty("end_time")]
 		public DateTime EndTime { get; internal set;  }
+		
 		[JsonProperty("end_time_in_millis")]
 		public long EndTimeInMilliseconds { get; internal set;  }
+		
 		[JsonProperty("duration_in_millis")]
 		public long DurationInMilliseconds { get; internal set;  }
-		[JsonProperty("failures")]
-		public IEnumerable<string> Failures { get; internal set;  }
+
 		[JsonProperty("shards")]
-		public ShardsMetaData Shards { get; internal set;  }
+		public ShardsMetaData Shards { get; internal set; }
+
+		[JsonProperty("failures")]
+		public IEnumerable<SnapshotShardFailure> ShardFailures { get; internal set; }
+
+		/// <summary>
+		/// Contains the reason for each shard failure.
+		/// For 2.0, remove this and rename ShardFailures => Failures
+		/// </summary>
+		public IEnumerable<string> Failures
+		{
+			get
+			{
+				if (this.ShardFailures != null) 
+					return this.ShardFailures.Select(f => f.Reason);
+				return new List<string>();
+			}
+		}
+		
 	}
 }

src/Nest/Domain/Repository/SnapshotShardFailure.cs

@@ -0,0 +1,27 @@
+using Newtonsoft.Json;
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Text;
+
+namespace Nest
+{
+	[JsonObject]
+	public class SnapshotShardFailure
+	{
+		[JsonProperty("node_id")]
+		public string NodeId { get; set; }
+
+		[JsonProperty("index")]
+		public string Index { get; set; }
+
+		[JsonProperty("shard_id")]
+		public string ShardId { get; set; }
+
+		[JsonProperty("reason")]
+		public string Reason { get; set; }
+
+		[JsonProperty("status")]
+		public string Status { get; set; }
+	}
+}

src/Nest/Nest.csproj

@@ -184,6 +184,7 @@
     <Compile Include="Domain\Mapping\SubMappings\FieldData\FieldDataStringMapping.cs" />
     <Compile Include="Domain\Mapping\SubMappings\NormsMapping.cs" />
     <Compile Include="Domain\Mapping\SubMappings\MappingTransform.cs" />
+    <Compile Include="Domain\Repository\SnapshotShardFailure.cs" />
     <Compile Include="Domain\Responses\ClusterRerouteResponse.cs" />
     <Compile Include="Domain\Cat\CatAliasesRecord.cs" />
     <Compile Include="Domain\Cat\CatAllocationRecord.cs" />