default max connections set to 0, placed async outside of semaphore if max conn is 0

Author: Mpdreamz

Diff for: src/Nest/Domain/Connection/Connection.cs

@@ -25,7 +25,8 @@ public Connection(IConnectionSettings settings)
 				throw new ArgumentNullException("settings");
 
 			this._ConnectionSettings = settings;
-			this._ResourceLock = new Semaphore(settings.MaximumAsyncConnections, settings.MaximumAsyncConnections);
+			var semaphore = Math.Max(1, settings.MaximumAsyncConnections);
+			this._ResourceLock = new Semaphore(semaphore, semaphore);
 			this._enableTrace = settings.TraceEnabled;
 		}
 
@@ -212,6 +213,9 @@ protected virtual ConnectionStatus DoSynchronousRequest(HttpWebRequest request,
 		protected virtual Task<ConnectionStatus> DoAsyncRequest(HttpWebRequest request, string data = null)
 		{
 			var tcs = new TaskCompletionSource<ConnectionStatus>();
+			if (this._ConnectionSettings.MaximumAsyncConnections <= 0)
+				return this.CreateIterateTask(request, data, tcs);
+
 			var timeout = this._ConnectionSettings.Timeout;
 			if (!this._ResourceLock.WaitOne(timeout))
 			{
@@ -227,20 +231,23 @@ protected virtual Task<ConnectionStatus> DoAsyncRequest(HttpWebRequest request,
 			}
 			try
 			{
-				//return Task.Factory.StartNew(() =>
-				//{
-					
-						this.Iterate(this._AsyncSteps(request, tcs, data), tcs);
-						return tcs.Task;
-					
-				//}, TaskCreationOptions.LongRunning);
+				return Task.Factory.StartNew(
+					() => this.CreateIterateTask(request, data, tcs).Result
+					, TaskCreationOptions.LongRunning
+				);
 			}
 			finally
 			{
 				this._ResourceLock.Release();
 			}
 		}
 
+		private Task<ConnectionStatus> CreateIterateTask(HttpWebRequest request, string data, TaskCompletionSource<ConnectionStatus> tcs)
+		{
+			this.Iterate(this._AsyncSteps(request, tcs, data), tcs);
+			return tcs.Task;
+		}
+
 		private IEnumerable<Task> _AsyncSteps(HttpWebRequest request, TaskCompletionSource<ConnectionStatus> tcs, string data = null)
 		{
 			using (var tracer = new ConnectionStatusTracer(this._ConnectionSettings.TraceEnabled))

Diff for: src/Nest/Domain/Connection/ConnectionSettings.cs

@@ -48,7 +48,7 @@ public ConnectionSettings(Uri uri)
 			this.Host = uri.Host;
 			this.Port = uri.Port;
 
-			this.MaximumAsyncConnections = 20;
+			this.MaximumAsyncConnections = 0;
 			this.DefaultTypeNameInferrer = this.LowerCaseAndPluralizeTypeNameInferrer;
 			this.DefaultIndices = new FluentDictionary<Type, string>();
 			this.DefaultTypeNames = new FluentDictionary<Type, string>();