fix #930 shard failures meta data are not exposed

Author: Mpdreamz

Diff for: src/Nest/Domain/Hit/ShardsMetaData.cs

@@ -1,4 +1,6 @@
-using Newtonsoft.Json;
+using System.Collections;
+using System.Collections.Generic;
+using Newtonsoft.Json;
 
 namespace Nest
 {
@@ -13,5 +15,25 @@ public class ShardsMetaData
 
         [JsonProperty]
         public int Failed { get; internal set; }
+
+        [JsonProperty("failures")]
+        public IEnumerable<ShardsFailureReason> Failures { get; internal set; }
     }
+
+	[JsonObject]
+	public class ShardsFailureReason
+	{
+		[JsonProperty("index")]
+		public string Index { get; internal set; }
+
+		[JsonProperty("shard")]
+		public int Shard { get; internal set; }
+
+		[JsonProperty("status")]
+		public int Status { get; internal set; }
+
+		[JsonProperty("reason")]
+		public string Reason { get; internal set; }
+
+	}
 }

Diff for: src/Tests/Nest.Tests.Unit/Nest.Tests.Unit.csproj

@@ -378,6 +378,7 @@
     <Compile Include="Reproduce\Reproduce806Tests.cs" />
     <Compile Include="Reproduce\Reproduce876Tests.cs" />
     <Compile Include="Reproduce\Reproduce926Tests.cs" />
+    <Compile Include="Search\Failures\ShardFailureTests.cs" />
     <Compile Include="Search\Fields\FieldsTests.cs" />
     <Compile Include="Search\Filter\Modes\ConditionlessFilterJson.cs" />
     <Compile Include="Search\Filter\Modes\FilterModesTests.cs" />
@@ -780,6 +781,9 @@
     <None Include="Reproduce\Issue876.json">
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </None>
+    <None Include="Search\Failures\ShardFailuresResult.json">
+      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
+    </None>
     <None Include="Search\Fields\FixedCovariantSearchResult.json">
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </None>

Diff for: src/Tests/Nest.Tests.Unit/Search/Failures/ShardFailureTests.cs

@@ -0,0 +1,32 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Reflection;
+using FluentAssertions;
+using Nest.Tests.MockData.Domain;
+using NUnit.Framework;
+
+namespace Nest.Tests.Unit.Search.Failures
+{
+	[TestFixture]
+	public class ShardFailureTests : BaseJsonTests
+	{
+		[Test]
+		public void ShardFailuresAreExposed()
+		{
+			var client = GetFixedReturnClient(MethodBase.GetCurrentMethod(), "ShardFailuresResult");
+
+			var result = client.Search<ElasticsearchProject>(s=>s.MatchAll());
+			result.IsValid.Should().BeTrue();
+
+			result.Shards.Should().NotBeNull();
+			result.Shards.Failures.Should().NotBeEmpty();
+			var shardFailure = result.Shards.Failures.First();
+			shardFailure.Index.Should().Be("<indexname>");
+			shardFailure.Reason.Should().Be("<error message>");
+			shardFailure.Status.Should().Be(500);
+			shardFailure.Shard.Should().Be(4);
+		}
+		
+	}
+}

Diff for: src/Tests/Nest.Tests.Unit/Search/Failures/ShardFailuresResult.json

@@ -0,0 +1,113 @@
+{
+	"took": 4,
+	"timed_out": false,
+	"_shards": {
+		"total": 5,
+		"successful": 5,
+		"failed": 1,
+		"failures": [
+			{
+				"index": "<indexname>",
+				"shard": 4,
+				"status": 500,
+				"reason": "<error message>"
+			}
+		]
+	},
+	"hits": {
+		"total": 1605,
+		"max_score": 1.0,
+		"hits": [
+			{
+				"_index": "default-index",
+				"_type": "classa",
+				"_id": "nl-a457f343-ae3e-43e0-865c-af4cd73f1ede",
+				"_score": 1.0,
+				"fields": {
+					"lang": [ "nl" ]
+				}
+			},
+			{
+				"_index": "default-index",
+				"_type": "classb",
+				"_id": "nl-ef598e58-53d6-4b04-9653-c1b5386ee13a",
+				"_score": 1.0,
+				"fields": {
+					"lang": [ "nl" ]
+				}
+			},
+			{
+				"_index": "default-index",
+				"_type": "classa",
+				"_id": "nl-101594bb-4dea-45be-9788-04a1ade0c3db",
+				"_score": 1.0,
+				"fields": {
+					"lang": [ "nl" ]
+				}
+			},
+			{
+				"_index": "default-index",
+				"_type": "classd",
+				"_id": "en-09058c83-59c4-48a8-a370-138dbdfdf524",
+				"_score": 1.0,
+				"fields": {
+					"lang": [ "en" ]
+				}
+			},
+			{
+				"_index": "default-index",
+				"_type": "classc",
+				"_id": "en-414aa648-c1a3-41d8-9db6-3df3724a8e98",
+				"_score": 1.0,
+				"fields": {
+					"lang": [ "en" ]
+				}
+			},
+			{
+				"_index": "default-index",
+				"_type": "classc",
+				"_id": "nl-030b56ef-d751-450f-870c-575c4d558e1e",
+				"_score": 1.0,
+				"fields": {
+					"lang": [ "nl" ]
+				}
+			},
+			{
+				"_index": "default-index",
+				"_type": "classc",
+				"_id": "nl-c423c8e2-6cf3-4a45-806a-c65a81d704d5",
+				"_score": 1.0,
+				"fields": {
+					"lang": [ "nl" ]
+				}
+			},
+			{
+				"_index": "default-index",
+				"_type": "classa",
+				"_id": "en-b11f98fc-231d-463b-aa3d-a8948f2f1d7b",
+				"_score": 1.0,
+				"fields": {
+					"lang": [ "en" ]
+				}
+			},
+			{
+				"_index": "default-index",
+				"_type": "classb",
+				"_id": "nl-4d2722ce-00be-41f8-82f1-8c447294587b",
+				"_score": 1.0,
+				"fields": {
+					"lang": [ "nl" ]
+				}
+			},
+			{
+				"_index": "default-index",
+				"_type": "classb",
+				"_id": "nl-c485ed76-4c50-49af-8630-0c6413b296d6",
+				"_score": 1.0,
+				"fields": {
+					"lang": [ "nl" ]
+				}
+			}
+		]
+	}
+}