Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong order of passed parameters in GeoBoundingBox method #1002

Closed
akisiel opened this issue Oct 17, 2014 · 2 comments
Closed

Wrong order of passed parameters in GeoBoundingBox method #1002

akisiel opened this issue Oct 17, 2014 · 2 comments

Comments

@akisiel
Copy link

akisiel commented Oct 17, 2014

Hi!

During development in our project we have discovered that in current version (we're using 1.1.1) there is wrong order of given parameters in GeoBoundingBox method.

In this method's signature you ask for: topLeftX (means top left corner longitide), topLeftY (top left corner latitude), bottomRightX (bottom right corner longitude) and bottomRightY (bottom right corner latitude) - https://github.com/elasticsearch/elasticsearch-net/blob/8a93e9d5afd21b075d8c5ddec489f7c5b4bbeceb/src/Nest/DSL/Filter/FilterDescriptor.cs#L175 . Parameters are passed to the json as a string in same order (means long, lat) while in elasticsearch documentation says that if you're passing data as a string you should pass first latitude and then longitude (http://www.elasticsearch.org/guide/en/elasticsearch/reference/current/query-dsl-geo-bounding-box-filter.html#_lat_lon_as_string_3). Can you please check this and correct?

@gmarz gmarz closed this as completed in 9149158 Oct 17, 2014
@gmarz
Copy link
Contributor

gmarz commented Oct 17, 2014

@akisiel

You are absolutely right, this is definitely a bug- a pretty bad one at that. I just pushed the above fix and we'll try and get a new release out asap. Thank you very much for finding and reporting this!

@gmarz gmarz added Bug labels Oct 17, 2014
@akisiel
Copy link
Author

akisiel commented Oct 20, 2014

No problem and thanks for quick solving :)

@gmarz gmarz added v1.2.0 and removed v1.1.3 labels Oct 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants