Skip to content

CountDescriptor.Query IQueryContainer support #1454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JamieDixon opened this issue Jun 12, 2015 · 2 comments
Closed

CountDescriptor.Query IQueryContainer support #1454

JamieDixon opened this issue Jun 12, 2015 · 2 comments

Comments

@JamieDixon
Copy link

Presently, SearchDescriptor.Query has an overload that takes an IQueryContainer.

It would be useful if CountDescriptor.Query also had an overload accepting an IQueryContainer.

This would allow us to pass the same incoming parameters to either method as required without the need to handle CountDescriptor.Query as a special case.
@gmarz
Copy link
Contributor

gmarz commented Jun 16, 2015

Agreed, this would be useful. Just thinking that if we did this, we'd have to be consistent and do the same for everywhere we have a Query()...

@Mpdreamz
Copy link
Member

Taking this on board because it was super easy to add, on our 2.0 branch we are making an effort in normalizing this across all descriptors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Mpdreamz @JamieDixon @gmarz