-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Move GetManyExtensions to IElasticClient interface #1627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I think it's prudent to keep any kind of convenience methods separate from the client in order to keep methods aligned with the Elasticsearch API. That said, we do have |
Agreed for the same reasons above. |
I meant to say I'm not dead set against :D We might re-evaluate come 3.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Would you consider a PR to move the extension methods from GetManyExtensions to the client interface? As it stands these methods are impossible mock out in unit testing using Rhino (and other mocking frameworks that can't deal with static methods).
The text was updated successfully, but these errors were encountered: