Skip to content

Move GetManyExtensions to IElasticClient interface #1627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rikkit opened this issue Nov 18, 2015 · 4 comments
Closed

Move GetManyExtensions to IElasticClient interface #1627

rikkit opened this issue Nov 18, 2015 · 4 comments

Comments

@rikkit
Copy link

rikkit commented Nov 18, 2015

Would you consider a PR to move the extension methods from GetManyExtensions to the client interface? As it stands these methods are impossible mock out in unit testing using Rhino (and other mocking frameworks that can't deal with static methods).

@Mpdreamz
Copy link
Member

Mpdreamz commented Jan 6, 2016

I mostly want to keep IElasticClient free of any of the "convenience" methods that do not really translate to an Elasticsearch API endpoint. I'm dead set against though, @gmarz @russcam you guys have a strong opinion on this?

@russcam
Copy link
Contributor

russcam commented Jan 9, 2016

I think it's prudent to keep any kind of convenience methods separate from the client in order to keep methods aligned with the Elasticsearch API.

That said, we do have ReIndex<T> on the client directly in master (though a ReIndex API is being proposed) 😄

@gmarz gmarz added this to the 2.0.0 RC milestone Jan 14, 2016
@gmarz gmarz removed this from the 2.0.0 milestone Jan 25, 2016
@gmarz
Copy link
Contributor

gmarz commented Jan 25, 2016

Agreed for the same reasons above.

@gmarz gmarz closed this as completed Jan 25, 2016
@Mpdreamz
Copy link
Member

I meant to say I'm not dead set against :D We might re-evaluate come 3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants