.ConfigureAwait(false) all async/await methods #1801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

russcam opened this issue Feb 4, 2016 · 1 comment

Contributor

russcam commented Feb 4, 2016

Since none of our async methods need to callback on the context, we should configure all async calls not to capture it.

russcam added Vote labels

russcam closed this as completed in

ebcd9d6

Contributor

niemyjski commented Sep 14, 2016

I took a look at the source code and it looks like you are missing them in quite a few spots: Here is one of them: https://github.com/elastic/elasticsearch-net/blob/master/src/Nest/Document/Multiple/BulkAll/BulkAllObservable.cs#L111 and pretty much every call to await Task.Delay(x). You may want to do a search for await the project and then in the find window search for configureawait and if you don't see one on every result line... You may be missing a spot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment