Skip to content

ScriptQuery mapping #1945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Mpdreamz opened this issue Mar 22, 2016 · 2 comments
Closed

ScriptQuery mapping #1945

Mpdreamz opened this issue Mar 22, 2016 · 2 comments

Comments

@Mpdreamz
Copy link
Member

See: #1944

We currently map script query as a single unit but we need to move the inline, file and id properties under another script property of type ScriptBlock.

This ScriptBlock should be used under ScriptScoreFunction rather then the whole ScriptQuery
@gmarz
Copy link
Contributor

gmarz commented Mar 22, 2016

We have IScript which we use everywhere a script can be specified. Can we use that instead?

@Mpdreamz
Copy link
Member Author

👍 good call, absolutely

-ScriptBlock
+IScript

@gmarz gmarz mentioned this issue Mar 23, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@russcam @Mpdreamz @gmarz